Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PLC4X with etherip #520

Merged
merged 14 commits into from
Aug 12, 2024
Merged

Replace PLC4X with etherip #520

merged 14 commits into from
Aug 12, 2024

Conversation

codepitbull
Copy link
Contributor

Motivation

Resolves #24713

Changes

  • Replaces PLC4X with etherip for Ethernet IP/CIP

@cla-bot cla-bot bot added the cla-signed label Aug 7, 2024
@codepitbull codepitbull force-pushed the bugfix/24713-move-to-etherip branch from 78212d8 to f9b39e4 Compare August 9, 2024 13:15
@codepitbull codepitbull marked this pull request as ready for review August 9, 2024 13:15
sfrehse
sfrehse reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sfrehse sfrehse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I proposed in the comment to remove the old implementation and fix the names such that current configuration just works with the new implementation

modules/hivemq-edge-module-etherip/build.gradle.kts Show resolved Hide resolved
modules/hivemq-edge-module-etherip/gradle/libs.versions.toml Outdated Show resolved Hide resolved
...therip/src/main/java/com/hivemq/edge/adapters/etherip/EtherIpProtocolAdapterInformation.java Outdated Show resolved Hide resolved
...therip/src/main/java/com/hivemq/edge/adapters/etherip/EtherIpProtocolAdapterInformation.java Outdated Show resolved Hide resolved
...module-etherip/src/main/java/com/hivemq/edge/adapters/etherip/model/EtherIpValueFactory.java Show resolved Hide resolved
@codepitbull codepitbull requested a review from sfrehse August 12, 2024 10:00
@codepitbull codepitbull merged commit 9bd0eb7 into master Aug 12, 2024
3 checks passed
@codepitbull codepitbull deleted the bugfix/24713-move-to-etherip branch August 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfrehse sfrehse sfrehse approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codepitbull @sfrehse