feat(20611): Add uniqueness validation to topic filter #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
fix/20611/topic-fitler-valisation
branch
from
6a419b9 to
9341559
Compare
oli-hivemq
reviewed
May 3, 2024
hivemq-edge/src/frontend/src/extensions/datahub/locales/en/datahub.json
Outdated
Show resolved
Hide resolved
oli-hivemq
approved these changes
May 3, 2024
vanch3d
force-pushed
the
fix/20611/topic-fitler-valisation
branch
from
9341559 to
fe99686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/20611/details/
The PR adds a custom validator to the
Topic Filterconfiguration panel, ensuring that the filter added to a data policy is not already in use in another policy. Note that the check is purely syntactic on the filter itself, not on the topics it migth match.Before
After