fix(17144): refactor table and panel not to show undefined information

hivemq · Oct 26, 2023 · 7d972d9 · 7d972d9
1 parent 96e53e6
commit 7d972d9
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 17 deletions.
diff --git a/hivemq-edge/src/frontend/src/modules/EventLog/components/panel/EventDrawer.tsx b/hivemq-edge/src/frontend/src/modules/EventLog/components/panel/EventDrawer.tsx
@@ -88,21 +88,30 @@ const EventDrawer: FC<BridgeMainDrawerProps> = ({ event, isOpen, onClose }) => {
                 <CardBody data-testid={'event-value-message'}>{event.message}</CardBody>
               </Card>
 
-              <Card w={'100%'}>
-                <CardHeader data-testid={'event-title-payload'}>
-                  {t('eventLog.table.header.payload')}
-                  <Badge variant="outline" mx={2}>
-                    {event.payload?.contentType}
-                  </Badge>
-                </CardHeader>
-                <CardBody>
-                  <Code w={'100%'} p={2} whiteSpace={'pre-wrap'}>
-                    {JSONFormat && JSONFormat}
-                    {XMLFormat && XMLFormat}
-                    {!isJSON && !isXML && event.payload?.content}
-                  </Code>
-                </CardBody>
-              </Card>
+              {event.payload && (
+                <Card w={'100%'}>
+                  <CardHeader data-testid={'event-title-payload'}>
+                    {t('eventLog.table.header.payload')}
+                    <Badge variant="outline" mx={2}>
+                      {event.payload?.contentType}
+                    </Badge>
+                  </CardHeader>
+                  <CardBody pt={0}>
+                    <Code
+                      w={'100%'}
+                      p={2}
+                      whiteSpace={'pre-wrap'}
+                      overflow={'auto'}
+                      sx={{ textWrap: 'nowrap' }}
+                      maxH={400}
+                    >
+                      {JSONFormat && JSONFormat}
+                      {XMLFormat && XMLFormat}
+                      {!isJSON && !isXML && event.payload?.content}
+                    </Code>
+                  </CardBody>
+                </Card>
+              )}
             </VStack>
           </DrawerBody>
         </DrawerContent>

diff --git a/hivemq-edge/src/frontend/src/modules/EventLog/components/table/EventLogTable.tsx b/hivemq-edge/src/frontend/src/modules/EventLog/components/table/EventLogTable.tsx
@@ -37,15 +37,15 @@ const EventLogTable: FC<EventLogTableProps> = ({ onOpen }) => {
         cell: (info) => {
           return (
             <Skeleton isLoaded={!isLoading}>
-              <Box whiteSpace={'nowrap'}>
+              {info.row.original.payload ? (
                 <IconButton
                   size={'sm'}
                   mr={2}
                   onClick={() => onOpen(info.row.original)}
                   aria-label={t('eventLog.table.cta.open')}
                   icon={<MdOutlineEventNote />}
                 />
-              </Box>
+              ) : null}
             </Skeleton>
           )
         },