Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Fix: Unified Logger Usage #209

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Typo Fix: Unified Logger Usage #209

merged 3 commits into from
Jul 30, 2024

Conversation

MooooCat
Copy link
Contributor

Description

This pull request introduces a unified approach to logger usage across the SDG framework. Previously, the logger was imported from different modules (sdgx.log), which led to inconsistencies and potential issues in logging management.

This change centralizes the logger usage by importing it from a common utility module (sdgx.utils), ensuring a consistent logging approach throughout the codebase.

Motivation and Context

By centralizing the logger in a utility module, we simplify maintenance, enhance readability, and ensure that all logging operations follow a consistent pattern.

This change also paves the way for future enhancements in logging, such as adding context-specific logging or integrating advanced logging features without the need for extensive code modifications.

How has this been tested?

The changes have been tested through automated unit tests to ensure that the logging functionality remains intact and operates as expected.

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat MooooCat changed the title Unified Logger Usage Typo Fix: Unified Logger Usage Jul 30, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (31eefae) to head (270c81c).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   81.76%   82.01%   +0.25%     
==========================================
  Files          79       80       +1     
  Lines        3909     3975      +66     
==========================================
+ Hits         3196     3260      +64     
- Misses        713      715       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat merged commit 2827bba into main Jul 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants