Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy<2 #190

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Pin numpy<2 #190

merged 2 commits into from
Jun 18, 2024

Conversation

Wh1isper
Copy link
Collaborator

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Wh1isper Wh1isper changed the title Try numpy >=2 Pin numpy<2 Jun 18, 2024
@Wh1isper
Copy link
Collaborator Author

@MooooCat numpy v2 is not compatible with the project, see this action: https://github.com/hitsz-ids/synthetic-data-generator/actions/runs/9567909279?pr=190

We may wait for numpy v2 to be more stable and compatible before we consider upgrading.

@Wh1isper Wh1isper merged commit 1ef4ca2 into main Jun 18, 2024
12 checks passed
@Wh1isper Wh1isper deleted the chore-test-numpy-2 branch June 18, 2024 15:39
@Wh1isper
Copy link
Collaborator Author

@MooooCat I think we may need to do a release(0.2.1) to include this change so that downstream users will not install numpy v2 due to pip's strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant