Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Metadata.column_list from Set to List #176

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Change Metadata.column_list from Set to List #176

merged 5 commits into from
Apr 21, 2024

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Apr 20, 2024 •
edited
Loading

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat MooooCat changed the title Change Metadata.column_list from set to list using @property Change Metadata.column_list from Set to List Apr 20, 2024
@MooooCat
Copy link
Contributor Author

@Wh1isper The Pydantic Basemodel works not well with python @Property check this, while Pydantic Field work fair well.

@MooooCat MooooCat marked this pull request as ready for review April 20, 2024 15:00
@MooooCat MooooCat requested a review from Wh1isper April 20, 2024 15:00
Wh1isper
Wh1isper approved these changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@Wh1isper Wh1isper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's sweet and with the original design

@MooooCat MooooCat merged commit 8f95941 into main Apr 21, 2024
12 checks passed
@MooooCat MooooCat deleted the enhance-use-list-in-metadata-column_list branch April 21, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wh1isper Wh1isper Wh1isper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MooooCat @Wh1isper