Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Poll when shutdown #74

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[BUG] Poll when shutdown #74

merged 2 commits into from
Sep 21, 2023

Conversation

wunder957
Copy link
Contributor

Description

Call the function after shutdown event is set, avoid data loss

Motivation and Context

Currently shutdown will shut down the poller directly, and we should collect all the data before shutting it down.

How has this been tested?

see tests/test_poller.py

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@wunder957 wunder957 added the bug Something isn't working label Sep 21, 2023
@wunder957 wunder957 added this to the v0.1.1 milestone Sep 21, 2023
@wunder957 wunder957 changed the title Poll when shutdown [BUG] Poll when shutdown Sep 21, 2023
@wunder957 wunder957 marked this pull request as ready for review September 21, 2023 03:07
@wunder957 wunder957 merged commit 1cf0dae into main Sep 21, 2023
5 checks passed
@wunder957 wunder957 deleted the feature-last-poll-when-shutdown branch September 21, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants