Fixes for offline mode for RedHat after testing

core/src/epicli/data/common/ansible/playbooks/roles/rabbitmq/tasks/Redhat.yml

@@ -1,9 +1,8 @@
-- name: Install Rabitmq packages
+- name: Install Rabbitmq packages
   yum:
     name:
       - socat
       - logrotate
-      - erlang
-      - rabbitmq-server
-    update_cache: yes
+      - erlang-21.3.* # order matters, check RabbitMQ/Erlang version compatibility matrix before modification
+      - rabbitmq-server-3.7.10
     state: present

core/src/epicli/data/common/ansible/playbooks/roles/repository/files/client/RedHat/create-enabled-system-repos-list.sh

@@ -3,5 +3,6 @@
 ENABLED_REPOS_FILE=/var/tmp/enabled-system-repos.txt
 
 if [ ! -f "$ENABLED_REPOS_FILE" ]; then
-  yum repolist enabled | awk '/^$/ {next}; /repo id/ {f=1; next}; /^repolist/ {f=0}; f {sub(/\/.*/,""); print $1}' > $ENABLED_REPOS_FILE
+  # 'yum repoinfo' or 'yum repolist -v' not used since they may require Internet access, even with --cacheonly
+  yum --cacheonly repolist enabled | awk '/^$/ {next}; /repo id/ {f=1; next}; /^repolist/ {f=0}; f {sub(/\/.*/,""); print $1}' > $ENABLED_REPOS_FILE
 fi

core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/download-requirements.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-# VERSION 1.2.3
+# VERSION 1.0.0
 
 set -euo pipefail
 
@@ -138,7 +138,7 @@ get_package_dependencies_with_arch() {
 	# $1 reserved for result
 	local package="$2"
 
-	local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package" 2>&1) ||
+	local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package") ||
 		exit_with_error "repoquery failed for dependencies of package: $package with exit code: $?, output was: $query_output"
 
 	if [[ -z $query_output ]]; then
@@ -156,7 +156,7 @@ get_package_with_version_arch() {
 	# $1 reserved for result
 	local package="$2"
 
-	local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package" 2>&1) ||
+	local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package") ||
 		exit_with_error "repoquery failed for package: $package with exit code: $?, output was: $query_output"
 
 	# yumdownloader doesn't set error code if repoquery returns empty output

core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/requirements.txt

@@ -15,7 +15,6 @@ systemd-sysv
 
 [packages]
 audit # for docker-ce
-audit-libs # for docker-ce
 bash-completion
 ca-certificates
 cifs-utils

core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/download-requirements.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-# VERSION 1.2.3
+# VERSION 1.0.0
 
 set -euo pipefail
 
@@ -155,7 +155,7 @@ get_package_dependencies_with_arch() {
 	# $1 reserved for result
 	local package="$2"
 
-	local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package" 2>&1) ||
+	local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package") ||
 		exit_with_error "repoquery failed for dependencies of package: $package with exit code: $?, output was: $query_output"
 
 	if [[ -z $query_output ]]; then
@@ -173,7 +173,7 @@ get_package_with_version_arch() {
 	# $1 reserved for result
 	local package="$2"
 
-	local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package" 2>&1) ||
+	local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package") ||
 		exit_with_error "repoquery failed for package: $package with exit code: $?, output was: $query_output"
 
 	# yumdownloader doesn't set error code if repoquery returns empty output

core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/requirements.txt

@@ -8,7 +8,6 @@ yum-utils
 
 [packages]
 audit # for docker-ce
-audit-libs # for docker-ce
 bash-completion
 ca-certificates
 cifs-utils

core/src/epicli/data/common/ansible/playbooks/roles/repository/files/server/RedHat/create-repository.sh

@@ -4,6 +4,7 @@ EPI_REPO_SERVER_PATH=$1 # /var/www/html/epirepo is the default
 IS_OFFLINE_MODE=$2
 
 if $IS_OFFLINE_MODE = true; then
+  # deprecated 'yum localinstall' is used since 'yum install' returns error code when 'nothing to do'
   yum localinstall -y $(ls $EPI_REPO_SERVER_PATH/packages/repo-prereqs/*.rpm)
 else
   yum install -y httpd createrepo yum-utils

core/src/epicli/data/common/ansible/playbooks/roles/repository/tasks/setup.yml

@@ -62,7 +62,7 @@
 
 - name: Copy requirements for offline installation to repository host
   copy:
-    src: "{{ offline_requirements }}/" #TODO: handle case with double slash
+    src: "{{ offline_requirements }}/"
     dest: /var/www/html/epirepo
     force: no # if target exists it will skip, default is 'yes'
   when: