AzureCLI integration #427
Merged
AzureCLI integration #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seriva
commented
Aug 7, 2019
•
seriva
commented
- Added login to Azure-CLI and selection of subscription.
- Added creation of service principle.
- Added creation of the resource group.
- Added possibility to run without service principal
- Added changelog - Added versions to for components - Minor documentation updates - Removed unused documentation
- Added creation of service principle. - Added creation of the resource group.
erzetpe
previously approved these changes
Aug 7, 2019
lukurde
previously approved these changes
Aug 7, 2019
lukurde
previously approved these changes
Aug 8, 2019
erzetpe
suggested changes
Aug 8, 2019
| vnet_address_pool: 10.1.0.0/20 | ||
| use_public_ips: False # When not using public IPs you have to provide connectivity via private IPs (VPN) | ||
| use_service_principle: False |
There was a problem hiding this comment.
should be probably use_service_principal
There was a problem hiding this comment.
do we also need this for AWS?
erzetpe
approved these changes
Aug 8, 2019
lukurde
approved these changes
Aug 8, 2019
to-bar
pushed a commit
to to-bar/epiphany
that referenced
this pull request
May 6, 2020
* - Added login to Azure-CLI and selection of subscription. - Added creation of service principle. - Added creation of the resource group. * - Added posibility to run without service principal * - Changed text outputs * - Fixed typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.