Feature/3190 expand k8s nodes capabilities with storage from rook #3217
Conversation
| @@ -6,3 +6,4 @@ specification: | |||
| version: 1.22.4 | |||
| cni_version: 0.8.7 | |||
| node_labels: "node-type=epiphany" | |||
| enable_controller_attach_detach: false | |||
There was a problem hiding this comment.
As proposed by @to-bar, we can move this argument to kubernetes-master configuration.
Name of the file we want to move it to: schema/common/defaults/configuration/kubernetes-master.yml
| @@ -10,3 +10,4 @@ nodeRegistration: | |||
| kubeletExtraArgs: | |||
| enable-controller-attach-detach: "false" | |||
| node-labels: {{ specification.node_labels }} | |||
| enable_controller_attach_detach: "{{ specification.enable_controller_attach_detach }}" | |||
There was a problem hiding this comment.
As commented #3190 (comment), we don't want to setup this flag in kubeadm-join-node, so this argument shouldn't be present in this file.
Only location to configure this argument should be ansible/playbooks/roles/kubernetes_master/templates/kubeadm-config.yml.j2
| @@ -1,4 +1,9 @@ | |||
| --- | |||
| - name: Load default variables for k8s nodes | |||
There was a problem hiding this comment.
After moving parameter enable_controller_attach_detach to schema/common/defaults/configuration/kubernetes-master.yml loading default variables for k8s nodes will be obsolete.
| @@ -61,3 +61,4 @@ kind: KubeletConfiguration | |||
| apiVersion: kubelet.config.k8s.io/v1beta1 | |||
| cgroupDriver: systemd | |||
| rotateCertificates: true | |||
| enableControllerAttachDetach: {{ kubernetes_node_vars.specification.enable_controller_attach_detach }} | |||
There was a problem hiding this comment.
After moving parameter enable_controller_attach_detach to schema/common/defaults/configuration/kubernetes-master.yml it can look like that:
| enableControllerAttachDetach: {{ kubernetes_node_vars.specification.enable_controller_attach_detach }} | |
| enableControllerAttachDetach: {{ specification.enable_controller_attach_detach }} |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing as a new pull was made for this: #3237 |
tomasz-baran
deleted the
feature/3190-expand-k8s-nodes-capabilities-with-storage-from-rook
branch
WIP state.