Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development improvements #3032

Merged
merged 15 commits into from
Mar 24, 2022
Merged

Development improvements #3032

merged 15 commits into from
Mar 24, 2022

Conversation

to-bar
Copy link
Contributor

@to-bar to-bar commented Mar 18, 2022 •
edited
Loading

VSCode:

  • Use VSCode native API and UI for running tests
  • Remove obsolete VSCode settings
  • Refactor tasks.json

pylint:

  • Fix import issues for download-requirements
  • Update py-version

pytest:

  • Add download-requirements tests to pytest.ini
  • Ignore only known warnings
  • Do not use deprecated distutils package
  • Use default junit_family
  • Refactor pytest.ini
  • Fix yum tests

@to-bar to-bar self-assigned this Mar 18, 2022
@to-bar to-bar requested a review from seriva March 18, 2022 10:33
atsikham
atsikham previously approved these changes Mar 18, 2022
View reviewed changes
@to-bar to-bar requested a review from sbbroot March 18, 2022 10:47
@seriva
Copy link
Collaborator

seriva commented Mar 18, 2022

No changes to https://github.com/epiphany-platform/epiphany/blob/6fa3ef173f8e7ea276ebf24ea28dbf24ecb0219d/.vscode/tasks.json#L9 are needed?

seriva
seriva previously approved these changes Mar 18, 2022
View reviewed changes
@to-bar to-bar force-pushed the python-unit-tests branch from 831611a to 7ac074b Compare March 18, 2022 15:40
@to-bar to-bar force-pushed the python-unit-tests branch from 7ac074b to 84d3f8d Compare March 18, 2022 15:47
@to-bar
Copy link
Contributor Author

to-bar commented Mar 18, 2022

No changes to
https://github.com/epiphany-platform/epiphany/blob/6fa3ef173f8e7ea276ebf24ea28dbf24ecb0219d/.vscode/tasks.json#L9
are needed?

Good point, added new task Pylint download-requirements. pytest tests include download-requirements based on pytest.ini.

@to-bar to-bar requested a review from seriva March 22, 2022 08:53
@seriva
Copy link
Collaborator

seriva commented Mar 23, 2022

IMO we can merge this with one more review as it only touches tests and devtools which for me all worked fine when testing it.

@seriva seriva requested a review from atsikham March 23, 2022 09:03
@to-bar to-bar merged commit ce6a086 into develop Mar 24, 2022
@to-bar to-bar deleted the python-unit-tests branch March 24, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriva seriva seriva approved these changes

@erzetpe erzetpe erzetpe approved these changes

@sbbroot sbbroot Awaiting requested review from sbbroot

@atsikham atsikham Awaiting requested review from atsikham

Assignees

@to-bar to-bar

Labels
area/development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@to-bar @seriva @erzetpe @atsikham