Extend k8s schema validation #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriva
previously approved these changes
Jan 26, 2022
erzetpe
previously approved these changes
Jan 26, 2022
|
/azp run |
|
@atsikham validation for min and max values for certificate |
|
@seriva do you have any idea why it works a bit weird? and when setting a number outside the range 1-24855 it fails after terraform 😨 OK I get it, when having different data types it fails on merging, and all the validation is performed later. |
przemyslavic
approved these changes
Feb 4, 2022
|
However, I still believe that all validation should be executed before the terraform part. |
erzetpe
approved these changes
Feb 4, 2022
cicharka
added a commit
that referenced
this pull request
Feb 8, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
rafzei
pushed a commit
to rafzei/epiphany
that referenced
this pull request
Feb 8, 2022
erzetpe
added a commit
to erzetpe/epiphany
that referenced
this pull request
Feb 9, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Feb 9, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
to erzetpe/epiphany
that referenced
this pull request
Feb 10, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
to erzetpe/epiphany
that referenced
this pull request
Feb 24, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
to erzetpe/epiphany
that referenced
this pull request
Feb 24, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
to erzetpe/epiphany
that referenced
this pull request
Feb 24, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
to erzetpe/epiphany
that referenced
this pull request
Feb 24, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Feb 24, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Mar 1, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Mar 3, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Mar 8, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Mar 22, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Apr 4, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
cicharka
pushed a commit
to cicharka/epiphany
that referenced
this pull request
Apr 11, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
cicharka
pushed a commit
to cicharka/epiphany
that referenced
this pull request
Apr 11, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
cicharka
pushed a commit
to cicharka/epiphany
that referenced
this pull request
Apr 11, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
cicharka
pushed a commit
to cicharka/epiphany
that referenced
this pull request
Apr 11, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
cicharka
pushed a commit
to cicharka/epiphany
that referenced
this pull request
Apr 11, 2022
* K8s improvements (hitachienergy#2918) * Removal of Logstash component - next steps hitachienergy#2833 (hitachienergy#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (hitachienergy#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (hitachienergy#2929) * Extend deprecation note with Ignite removal steps (hitachienergy#2949) * Escalate permissions for ip command (hitachienergy#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (hitachienergy#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: hitachienergy#1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag hitachienergy#959 - Updated DoD for bugs to reflect changes made for hitachienergy#2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
cicharka
pushed a commit
that referenced
this pull request
Apr 11, 2022
* K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]>
erzetpe
added a commit
that referenced
this pull request
Apr 20, 2022
* Define additional disks with defined sizes to VMs for Azure (#2953) * Additional disks for azure DRAFT * Simplify config * add changelog note * Change starting index value in names * Change value of lun attribute to alling with disks indexing * Merge 'develop' into 'feature/rook-ceph-storage' (#2959) * K8s improvements (#2918) * Removal of Logstash component - next steps #2833 (#2941) * Add information about manual package removal that needs to be performed by cluster admin * include information about inventory file * Fix for ansible_default_ipv4 empty value (#2922) * Fix for ansible_default_ipv4 empty value * Fix after ToBar review * Add check if there is only one default routing config * Add check for different metrics value in case more than one default routing * Review fixes * Update fail_msg Co-authored-by: to-bar <[email protected]> * Extend k8s schema validation (#2929) * Extend deprecation note with Ignite removal steps (#2949) * Escalate permissions for ip command (#2952) * Changed autoscaling_group to plain EC2 VMs on AWS. (#2939) - Replaced AWS auto_scaling_groups with plain EC2 VM creation. - Added proper host sorting how it was implemented for the any and azure providers: #1076 - Sync up features with Azure Terraform implementation - Added support for use_network_security_groups flag #959 - Updated DoD for bugs to reflect changes made for #2832 Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]> * Add Ansible Rook role (#2960) * Add initial ansible rook role * Fix issue with no yet existing template * Add Rook schema related files * Remove already setup vars, add missing enters * Fix issue with feature mapping * Add configuration support * Move kubeconfig to rook role yaml * Update changelog * Add started dashes to yaml defaults for Rook * Add RH fix suggested by cicharka * Add rook cluster helm chart installation * Add separate chart values definitions * Limit fact checking in rook role * Add initial rook/ceph documentation * Update documentation for Rook * Update download requirements * Persistent Storage: Note about disks on AWS (#2998) * Updated changelog * Rearrange and update documentation * Update components * Fix after review * Limit hosts where apply is specified * Add comment about repository facts gathering * Make rook namespace configurable * Add linter comments to disable false positive * Add requested comments * Change shell to command module * Change mode to preserve for temp configuration data * Update documentation * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml Co-authored-by: przemyslavic <[email protected]> * use newer version of rook (#3053) * Feature/rook ceph storage additions (#3064) * rook/ceph: add default values in epiphany configuration * rook/ceph (#3068) * add default values in epiphany configuration * bump up verison of rook * Revert schema defaults (#3074) * Revert "rook/ceph (#3068)" This reverts commit 989be85. * Revert "Feature/rook ceph storage additions (#3064)" This reverts commit 17c49af. * minor fixes for schema and docs * add rook feature_mapping for single and custom * rook: modify tests and schema for image registry * rook: offline mode * enahnce playbook to allow chart files use images from local image registry * remove unused condition for chart and operator specification which is always defined now * modify path for rook/ceph image in order to be compliant with values.yml Signed-off-by: cicharka <[email protected]> * rook: add missing csiaddons for offline mode Signed-off-by: cicharka <[email protected]> Co-authored-by: Anatoli Tsikhamirau <[email protected]> Co-authored-by: Irek Głownia <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]> Co-authored-by: cicharka <[email protected]> Co-authored-by: przemyslavic <[email protected]> Co-authored-by: cicharka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @seriva, there is no possibility for now to check additional fields and that's done by purpose and such behavior was requested before.
So this PR is only about schema extension with a basic validation.