Added hostname_domain_extension. #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
/azp run |
atsikham
suggested changes
Dec 17, 2021
|
Works as expected, will give approve after other reviews |
rafzei
previously approved these changes
Dec 17, 2021
atsikham
previously approved these changes
Dec 17, 2021
rafzei
previously approved these changes
Dec 20, 2021
|
We have to backport it to LTS |
13 tasks
atsikham
dismissed
their stale review
There is no cluster config validation update - https://github.com/seriva/epiphany/blob/feature/2768/schema/common/validation/epiphany-cluster.yml.
atsikham
approved these changes
Dec 28, 2021
rafzei
approved these changes
Dec 28, 2021
|
@przemyslavic FYI: I've tested it on Azure/Ubuntu, same APM. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for the proposal here: #2768 (comment)
Can be reviewed and tested, some documentation will be added after @rafzei confirms this is ok for the team that requested it.