Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade pgbouncer and pgpool #2462

Conversation

plirglo
Copy link
Contributor

@plirglo plirglo commented Jul 23, 2021

Upgrade pgpool to v4.2.3 and pgbouncer to v1.15

This PR contains also changes from #2428 since those components should be tested in one pipeline

HA with pgpool and pgbouncer works only with md5 passwords - support for scram sha-256 will not be added in this case since it's impossible to automate generate users files basing on SHA.

Postgres

PgPool:

  • Configuration with pgpool version 4.2.3 (upgraded)
  • libpgpool.sh scipt is mostly developed by Bitnami, i've only adde some minor changes do adjust configuration for Epiphany case - original file is located here
  • some other modifications in init scripts required by newer version of pgpool
  • minor required changes in pgpool.conf file

PgBouncer:

  • Configuration with pgbouncer version 1.15 (upgraded / switched to Bitnami image)
  • libpgbouncer.sh scipt is developed by Bitnami, i've only adde some minor changes do adjust configuration for Epiphany case - original file is located script
  • Added pgbouncer.ini to configmap

plirglo and others added 27 commits May 18, 2021 11:39
* Removed auto generated vars

* Updated postgresql default configuration with correct settings

* Updated tests according to the new version

* Increased postgresql, pgaudit, pgpool, repmgr versions

* Postgres installation

* Repmgr RedHat installation

* Commented pgbouncer package not to fail installation

* Ubuntu installation except pgbouncer

* Updated components

* Added molecule tests and documentation

* Modified vars

* Asciidoc to markdown

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/molecule/debian-repmgr/prepare.yml

Co-authored-by: to-bar <[email protected]>

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/molecule/debian-repmgr/verify.yml

Co-authored-by: to-bar <[email protected]>

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/molecule/redhat-repmgr/prepare.yml

Co-authored-by: to-bar <[email protected]>

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/templates/pg_hba.conf.j2

Co-authored-by: to-bar <[email protected]>

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/tasks/extensions/replication/extension.yml

Co-authored-by: to-bar <[email protected]>

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/tasks/extensions/replication/extension.yml

Co-authored-by: to-bar <[email protected]>

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/tasks/extensions/replication/extension.yml

Co-authored-by: to-bar <[email protected]>

* Applied requested changes after review

* Update core/src/epicli/data/common/ansible/playbooks/roles/postgresql/tasks/main.yml

Co-authored-by: to-bar <[email protected]>

* Fixed repmgr check

* Require 2 hosts for replication

* Improve molecule tests

* Add {{ ansible_managed }} to templates

* Remove unused templates

* Improve task names

* Do not hide all failures of "Get cluster status" task

Co-authored-by: atsikham <[email protected]>
Co-authored-by: to-bar <[email protected]>
* Get rid of cacheable facts

* Applied review suggestion with ternary filter

Co-authored-by: atsikham <[email protected]>
@plirglo plirglo marked this pull request as ready for review July 23, 2021 10:59
@atsikham atsikham changed the base branch from feature/upgrade-postgresql to feature/upgrade-postgresql-13 July 28, 2021 08:26
@atsikham atsikham changed the base branch from feature/upgrade-postgresql-13 to feature/upgrade-postgresql July 28, 2021 08:26
@atsikham atsikham changed the base branch from feature/upgrade-postgresql to feature/upgrade-postgresql-13 July 28, 2021 09:39
@atsikham atsikham changed the base branch from feature/upgrade-postgresql-13 to feature/upgrade-postgresql July 28, 2021 09:40
@atsikham
Copy link
Contributor

Target branch feature/upgrade-postgresql was replaced by feature/upgrade-postgresql-13, please change that for this PR.

@plirglo plirglo changed the base branch from feature/upgrade-postgresql to feature/upgrade-postgresql-13 August 4, 2021 13:53
@plirglo plirglo force-pushed the feature/upgrade-pgbouncer branch 3 times, most recently from 476dfe7 to 81cb62d Compare August 6, 2021 07:27
erzetpe
erzetpe previously approved these changes Aug 9, 2021
rafzei
rafzei previously approved these changes Aug 10, 2021
Copy link
Contributor

@rafzei rafzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for your info:
I see there are already the newest versions:
Pgpool 4.2.4
Bitnami link
PGbouncer
Bitnami link
There is also one fix in md5 context

@plirglo plirglo dismissed stale reviews from rafzei and erzetpe via 9091ee6 August 10, 2021 06:07
@plirglo plirglo force-pushed the feature/upgrade-pgbouncer branch from 81cb62d to 9091ee6 Compare August 10, 2021 06:07
@plirglo
Copy link
Contributor Author

plirglo commented Aug 10, 2021

Just for your info:
I see there are already the newest versions:
Pgpool 4.2.4
Bitnami link
PGbouncer
Bitnami link
There is also one fix in md5 context

Thanks, we don't use md5 encryption with plain-text passwords, so i think this should not impact our configuration

@plirglo plirglo merged commit b22d29f into hitachienergy:feature/upgrade-postgresql-13 Aug 10, 2021
@plirglo
Copy link
Contributor Author

plirglo commented Aug 10, 2021

Applies also to task #2076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants