Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repmgrd service on Ubuntu #2451

Merged
merged 6 commits into from
Jul 22, 2021
Merged

Fix repmgrd service on Ubuntu #2451

merged 6 commits into from
Jul 22, 2021

Conversation

to-bar
Copy link
Contributor

@to-bar to-bar commented Jul 21, 2021

  • Set 'daemonize=false' option in /etc/default/repmgrd
  • Add test for 'repmgr service status'
  • Update postgres user in sudoers file

@to-bar to-bar self-assigned this Jul 21, 2021
@to-bar to-bar requested a review from atsikham July 21, 2021 18:00
@to-bar to-bar mentioned this pull request Jul 21, 2021
Closed
11 tasks
@atsikham atsikham mentioned this pull request Jul 21, 2021
Merged
@to-bar to-bar requested a review from erzetpe July 22, 2021 06:25
@przemyslavic
Copy link
Collaborator

/azp run

@przemyslavic
Copy link
Collaborator

przemyslavic commented Jul 22, 2021 •
edited
Loading

Tested on AWS Ubuntu:

   ID | Name                                              | Role    | Status    | Upstream                                          | repmgrd     | PID | Paused? | Upstream last seen
----+---------------------------------------------------+---------+-----------+---------------------------------------------------+-------------+-----+---------+--------------------
 1  | ec2-1-1-1-1.eu-west-1.compute.amazonaws.com | primary | * running |                                                   | not running | n/a | n/a     | n/a                
 2  | ec2-2-2-2-2.eu-west-1.compute.amazonaws.com  | standby |   running | ec2-1-1-1-1.eu-west-1.compute.amazonaws.com | not running | n/a | n/a     | n/a

repmgr is not running :( (tests failed)

@to-bar to-bar force-pushed the fix/upgrade-repmgr-pg10 branch from e5db68c to 8cace34 Compare July 22, 2021 08:42
@przemyslavic
Copy link
Collaborator

/azp run

atsikham
atsikham approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...li/data/common/ansible/playbooks/roles/postgresql/tasks/extensions/replication/extension.yml
@@ -18,8 +18,7 @@
/bin/systemctl restart {{ pg.service_name[ansible_os_family] }},
/bin/systemctl reload {{ pg.service_name[ansible_os_family] }},
/bin/systemctl start {{ repmgr.service_name[ansible_os_family] }},
/bin/systemctl stop {{ repmgr.service_name[ansible_os_family] }},
{{ repmgr.bin_dir[ansible_os_family] }}/repmgr standby follow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

...n/ansible/playbooks/roles/postgresql/tasks/upgrade/extensions/replication/repmgr-upgrade.yml
- name: repmgr for PG {{ pg_version }} | Update postgres user in sudoers file
lineinfile:
path: /etc/sudoers
regexp: "^postgres ALL=\\(ALL:ALL\\) NOPASSWD:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@to-bar to-bar merged commit f99af04 into hitachienergy:develop Jul 22, 2021
@to-bar to-bar deleted the fix/upgrade-repmgr-pg10 branch July 22, 2021 15:01
sbbroot pushed a commit to sbbroot/epiphany that referenced this pull request Aug 17, 2021
@to-bar @sbbroot
Fix repmgrd service on Ubuntu (hitachienergy#2451)
8d7bcdf 
* Set 'daemonize=false' option

* Shorter test names

* Add test for 'repmgr service status'

* Update postgres user in sudoers file

* Remove 'repmgr standby follow' from sudoers

* Remove backslashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemyslavic przemyslavic przemyslavic approved these changes

@atsikham atsikham atsikham approved these changes

@erzetpe erzetpe erzetpe approved these changes

Assignees

@to-bar to-bar

Labels
area/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@to-bar @przemyslavic @erzetpe @atsikham