Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cached facts usage #2444

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Fixed cached facts usage #2444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597630a
Get rid of cacheable facts
atsikham Jul 21, 2021
a982270
Applied review suggestion with ternary filter
atsikham Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions core/src/epicli/data/common/ansible/playbooks/roles/postgresql/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,23 @@
| map(attribute='name')
| list }}

- name: Check if repmgr.conf exists
stat:
path: "{{ repmgr.config_dir[ansible_os_family] }}/repmgr.conf"
register: repmgr_conf

- name: Get node id
when: repmgr_conf.stat.exists
command: >-
grep -Po '(?<=^node_id=)\d+' "{{ repmgr.config_dir[ansible_os_family] }}/repmgr.conf"
register: repmgr_pg_node_id
changed_when: false

# Node id is a constant value independent on order in Ansible host group
- name: Set 'pg_node_id' fact
set_fact:
pg_node_id: >-
{{ pg_node_id | default(groups.postgresql.index(inventory_hostname) + 1) }}
cacheable: true
{{ repmgr_conf.stat.exists | ternary(repmgr_pg_node_id.stdout, groups.postgresql.index(inventory_hostname) + 1) }}

- name: Install OS-specific packages
package:
Expand Down Expand Up @@ -164,7 +175,7 @@
postgresql_info:
filter: in_recovery
register: in_recovery_state

- name: Extensions | Set up PgPool | Create configuration
block:
- name: Extensions | Include PgPool vars from applications role
Expand All @@ -185,7 +196,7 @@
| list
| first
| default({}) }}
when:
when:
- not in_recovery_state.in_recovery
when:
- pgpool.env is defined