Preservation of OS images when re-runnning 'epicli apply'

[seriva]

• Implemented a mechanism to use the current OS images for every OS and not only the default we have defined for Ubuntu.
• Added option for preservation of OS images when re-runnning 'epicli apply' for existing cluster. In both cases a warning will be shown to preserve the images.
• Removed commented out validation command is we will not be implementing that anymore in Epicli.

[przemyslavic]

/azp run

[przemyslavic]

/azp run

[przemyslavic]

Unit tests fail:

=================================== FAILURES ===================================
_____________ test_get_public_ip_should_set_proper_values_to_model _____________

    def test_get_public_ip_should_set_proper_values_to_model():
        cluster_model = get_cluster_model(cluster_name='TestCluster')
        builder = InfrastructureBuilder([cluster_model])

        component_value = dict_to_objdict({
            'machine': 'kubernetes-master-machine'
        })
>       vm_config = builder.get_virtual_machine(component_value, cluster_model, [], [], False)
E       TypeError: get_virtual_machine() takes 2 positional arguments but 6 were given

tests/engine/providers/azure/test_AzureConfigBuilder.py:71: TypeError
_________ test_get_network_interface_should_set_proper_values_to_model _________

    def test_get_network_interface_should_set_proper_values_to_model():
        cluster_model = get_cluster_model(cluster_name='TestCluster')
        builder = InfrastructureBuilder([cluster_model])
        component_value = dict_to_objdict({
            'machine': 'kubernetes-master-machine'
        })
>       vm_config = builder.get_virtual_machine(component_value, cluster_model, [], [], False)
E       TypeError: get_virtual_machine() takes 2 positional arguments but 6 were given

tests/engine/providers/azure/test_AzureConfigBuilder.py:87: TypeError
- generated xml file: /azp/agent/_work/6/s/core/src/epicli/tests/results/result.xml -
=========================== short test summary info ============================
FAILED tests/engine/providers/azure/test_AzureConfigBuilder.py::test_get_public_ip_should_set_proper_values_to_model
FAILED tests/engine/providers/azure/test_AzureConfigBuilder.py::test_get_network_interface_should_set_proper_values_to_model
=================== 2 failed, 61 passed, 2 skipped in 0.52s ====================

[przemyslavic]

/azp run

[mkyc]

Shouldn't we update automated tests to ensure that os version didn't change in apply -> upgrade -> apply scenario? @przemyslavic can you help here? Do we have any automated tests for this? Where should we update?

[seriva]

Shouldn't we update automated tests to ensure that os version didn't change in apply -> upgrade -> apply scenario? @przemyslavic can you help here? Do we have any automated tests for this? Where should we update?

Unit tests are updated, as the automated tests, that is probably more a pipeline thing which I think @przemyslavic was already setting up?

[przemyslavic]

As discussed during the standup, unit tests should be sufficient here. A pipeline for testing the LTS version has already been created.

[przemyslavic]

/azp run