Improvements for changing K8s certificates expiration date #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsikham
force-pushed
the
feature/improvements-after-backport
branch
from
bcae7a4 to
8bd83ca
Compare
atsikham
force-pushed
the
feature/improvements-after-backport
branch
from
0d434e5 to
42345fa
Compare
to-bar
changed the title
seriva
approved these changes
Oct 30, 2020
sk4zuzu
approved these changes
Oct 30, 2020
rafzei
pushed a commit
to rafzei/epiphany
that referenced
this pull request
Nov 26, 2020
…ergy#1803) * Changes after backport * Made changes according to the latest review * Removed unnecessary quotes * Added information about expiration_days max value * Added validation for kubernetes master config Co-authored-by: atsikham <[email protected]>
toszo
pushed a commit
to toszo/epiphany
that referenced
this pull request
Dec 5, 2020
…ergy#1803) * Changes after backport * Made changes according to the latest review * Removed unnecessary quotes * Added information about expiration_days max value * Added validation for kubernetes master config Co-authored-by: atsikham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to keep on track with previous versions. Done after #1796, #1799 and #1802