Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for changing Terraform templates between epicli apply runs #1573

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fix for changing Terraform templates between epicli apply runs #1573

merged 2 commits into from
Aug 20, 2020

Conversation

seriva
Copy link
Collaborator

@seriva seriva commented Aug 20, 2020

Small fix done while researching #1570. It does not fix this issue but it does make sure the Terraform templates do not change in subsequent Epicli apply runs with unchanged config yaml

In this case the generation of a VM password on linux was removed as it is not needed by Terraform or used by Epiphany since we use SSH.

https://www.terraform.io/docs/providers/azurerm/r/virtual_machine.html#admin_password

Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seriva seriva merged commit 9ff628b into hitachienergy:develop Aug 20, 2020
@to-bar to-bar changed the title Fixs for changing Terraform templates between Epicli apply runs Fix for changing Terraform templates between epicli apply runs Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants