make-download-requirements-more-stable #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the order of executing the task download-requirements.yml after we populate the directory /tmp/epi-repository-setup-scripts.
I have hit a situation (many times when re-run from the current system) that this role failed because the script
core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/ubuntu-18.04/download-requirements.sh
this part
```
repos_backup_file="/tmp/epi-repository-setup-scripts/enable-system-repos.sh"
if [[ ! -f /etc/apt/sources.list ]]; then
if [[ -f /var/tmp/enabled-system-repos.tar ]] && [[ -f ${repos_backup_file} ]]; then
echol "OS repositories seems missing, restoring..."
${repos_backup_file}
else
echol "/etc/apt/sources.list seems missing, you either know what you're doing or you need to fix your repositories"
fi
fi
```
It comes to the the part `/etc/apt/sources.list seems missing, you either know what you're doing or you need to fix your repositories`
As you can see this relies on the /tmp/epi-repository-setup-scripts/enable-system-repos.sh.
- Set DEBIAN_FRONTEND=noninteractive for download-requirements.sh
A similar PR has been addressed this issues but in different place and because
that run before this stage the problem is hidden because these dependencies
packages are already install (libssl). However if you re-run it on existing
system it might happen again. Or in some combination situation it happened
again.
IMHO there is no side effect of adding this change to be sure we are not
prompted by apt for whatever reason.
added 2 commits
August 17, 2020 13:39
We did the similar already on Centos and Redhat (twice). I set it to 5 times for Ubuntu. Reason is I randomly got error downloading images - see the issue https://github.com/epiphany-platform/skopeo-bin/issues/7 for more information.
sk4zuzu
suggested changes
Aug 18, 2020
core/src/epicli/data/common/ansible/playbooks/roles/repository/tasks/setup.yml
Show resolved
Hide resolved
sk4zuzu
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have hit a situation (many times when re-run from the current system) that this role failed because the script
core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/ubuntu-18.04/download-requirements.sh
this part
It comes to the the part
/etc/apt/sources.list seems missing, you either know what you're doing or you need to fix your repositoriesAs you can see this relies on the /tmp/epi-repository-setup-scripts/enable-system-repos.sh.
A similar PR has been addressed this issues but in different place and because
that run before this stage the problem is hidden because these dependencies
packages are already install (libssl). However if you re-run it on existing
system it might happen again. Or in some combination situation it happened
again.
IMHO there is no side effect of adding this change to be sure we are not
prompted by apt for whatever reason.