-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround restart rabbitmq pods during patching #1395 #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafzei
suggested changes
Jul 28, 2020
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
ar3ndt
force-pushed
the
hotfix/rabbitmq-restart-pods
branch
from
July 31, 2020 08:29
222ffee
to
fe6d998
Compare
rafzei
suggested changes
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider also to add new line before the new task definition (to improve code reading)
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
sk4zuzu
suggested changes
Aug 3, 2020
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
sk4zuzu
previously requested changes
Aug 3, 2020
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
...li/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes/reconfigure-rabbitmq-app.yml
Outdated
Show resolved
Hide resolved
ar3ndt
force-pushed
the
hotfix/rabbitmq-restart-pods
branch
from
August 3, 2020 20:35
fe6d998
to
2d53074
Compare
mkyc
approved these changes
Aug 10, 2020
rafzei
approved these changes
Aug 10, 2020
erzetpe
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.