Add docker_version variable support #1477

ghost · 2020-07-17T07:43:25Z

Tested in AWS on Ubuntu, RedHat and deployment works properly.
Docker version for RedHat adjusted as per version available in our repo.
QUESTION: Should I test it on Azure and on Baremetal also in both version Ubuntu/Redhat?

mkyc · 2020-07-17T11:09:49Z

@mum0l Azure test is also important.

ghost · 2020-07-17T11:12:25Z

@mkyc sure, I will learn Azure DevOPS this weekend, and try to run tests in Monday

mkyc · 2020-07-17T11:19:05Z

You do not have to learn Azure DevOps now. Just run it in Azure Cloud setup. Maybe @przemyslavic can help you with that?

przemyslavic · 2020-07-17T11:44:07Z

@mkyc, @mum0l sure, I'll test all supported configurations.

to-bar · 2020-07-17T11:58:22Z

core/src/epicli/data/common/ansible/playbooks/roles/docker/defaults/main.yml

+docker_cli_version: "5:18.09.*"
+
+docker_version_rh: "3:18.09.*"
+docker_cli_version_rh: "1:19.03.*"


Suggested change

docker_version: "5:18.09.*"

docker_cli_version: "5:18.09.*"

docker_version_rh: "3:18.09.*"

docker_cli_version_rh: "1:19.03.*"

docker_version:

Debian: "5:18.09.*"

RedHat: "18.09.*"

We would like to have the same version for docker-ce and docker-ce-cli.

przemyslavic · 2020-07-17T12:06:35Z

@mum0l also remember about requirements.txt files (if you change package versions)

ghost · 2020-07-17T12:11:12Z

Thanks for comments guys! I will prepare new version, and put a comment here.

PS: Also I spoke with @przemyslavic and he will show me in Monday how can I test it using Azure DevOps pipelne.

mkyc

LGTM

ghost · 2020-07-21T14:52:17Z

Yesterday I did final fix, so now everything should be good.

@mkyc thx for approval.
@przemyslavic - today I test deployment via Azure Devops, building a cluster in both AWS and Azure, and no issues were found. Please review and approve.

ghost · 2020-07-22T13:04:13Z

Okey, its done.

Two tasks slimmed into one.
Adjusted variables
Two useless packages removed: apt-transport-https and ca-certificates (as they are installed thru: core\src\epicli\data\common\ansible\playbooks\roles\common\tasks\Debian.yml).

Tested in Azure Pipeline and deployment works properly on Debian/RH both on AWS and Azure.

mkyc

LGTM

* Initialized test status table * Added next sections of test status Refactored status table a bit, added next lines, added next section with descriptions. * Upgrade cluster section filled * All sections filled * Add missing tests * Move CNS proposition design doc to GH. * fixed formatting * Etcd encryption feature refactor for deployment and upgrades (#1427) * kubernetes_master: etcd encryption simplification and refactor * upgrade: refactor of upgrade-kubeadm-config.yml (proper yaml parsing) * upgrade: adding etcd encryption patching procedure * upgrade-master.yml: small coding style improvement (highlight fix) * upgrade: enabling patching of the kubeadm config * fact naming improvements Co-authored-by: to-bar <[email protected]> * patch-kubeadm-config.yml: skipping unnecessary kubectl apply Co-authored-by: to-bar <[email protected]> * Bumping AzureCLI to fix SP secrets with special characters. * Added Changelog entry. * Change move to copy build dir during an upgrade (#1429) * Change move to copy build dir during an upgrade * Got rid of unused backup_temp_dir * Update to logging - log piping for stderr. - custom colors for different log levels - mapping some cases of log warnings and errors from Terraform and Ansible * helm documentation #896 * Progress: - simplified piping * Fix K8s upgrade: 'kubeadm upgrade apply' hangs (#1431) * Clean up and optimize K8s upgrades * Patch only kubeadm-config ConfigMap * Downgrade CoreDNS to K8s built-in version before 'kubeadm upgrade apply' * Deploy customized CoreDNS after K8s is upgraded to the latest version * Update changelog * Wait for API resources to propagate * Rename vendor in VSCode recommendations (#1438) Vendor moved owner of mauve.terraform repository to HashiCorp (https://marketplace.visualstudio.com/items?itemName=HashiCorp.terraform) * Fix issue with Vault and Kubernetes Calico/Canal communication (#1434) * Add vault namespace and fixes related to connection issue * Add default policy for default namespace * Remove service endpoint, execute certificate part if enabled, setting protocol correctly in Vault Helm chart * Add possibility to configure manually Vault endpoint * Added changelog. * add howto links for helm doc * Update Changelog for #1438 (#1460) * Update Changelog * Update Changelog - add PR number * bump rabbitmq version from 3.7.10 to 3.8.3 #1395 * Changes in documentation after creating fix for calico and canal (#1459) * Changes after creating fix for calico and canal * Update changelog * Got rid of pipe and grep (#1472) * Assert that current version is upgradeable #1474 (#1476) * Assert that upgrade from current version is supported #1474 * Update core/src/epicli/data/common/ansible/playbooks/roles/upgrade/tasks/kubernetes.yml Co-authored-by: to-bar <[email protected]> * Add docker_version variable support (#1477) * add docker_version variable support * Docker installation - 2 tasks merged into 1 to speed up the deployment * Remove two useless packages from docker installation Co-authored-by: Grzegorz Dajuk <[email protected]> * Kubernetes HA upgrades (#1456) * epicli/upgrade: reusing existing shared-config + cleanups * upgrade: k8s HA upgrades minimal implementation * upgrade: kubernetes cleanup and refactor * Apply suggestions from code review Co-authored-by: to-bar <[email protected]> * upgrade: removing unneeded kubeconfig from k8s nodes (security fix) * upgrade: statefulset patching refactor * upgrade: cleanups and refactor for logs * Make deployment manifest tasks more generic * Improve detecting CNI plugin * AnsibleVarsGenerator.py: fixing regression issue introducted during upgrade refactor * Apply suggestions from code review Co-authored-by: to-bar <[email protected]> * upgrade: statefulset patching refactor - patching all containers (fix) - patching init containers also (fix) - removing include_tasks statements (speedup) * Ensure settings for backward compatibility * Revert "Ensure settings for backward compatibility" This reverts commit 5c9cdb6. * AnsibleInventoryUpgrade.py: merging shared-config with defaults * Adding changelog entry * Revert "AnsibleVarsGenerator.py: fixing regression issue introducted during upgrade refactor" This reverts commit c38eb9d. * Revert "epicli/upgrade: reusing existing shared-config + cleanups" This reverts commit e5957c5. * AnsibleVarsGenerator.py: adding nicer way to handle shared config Co-authored-by: to-bar <[email protected]> * Fix upgrade of flannel to v0.12.0 (#1484) * Readme and changelog update (#1493) Readme and changelog update * Fixing broken offline CentOS 7.8 installation (#1498) * repository: adding the missing centos-logos package * updating 0.7.1 changelog * repository/centos-7: restoring alphabetical order * Add modularization-approaches.md design document * Kibana config always points its elasticsearch.hosts to a "logging" VM (#1347) (#1483) * Bump elliptic from 6.5.0 to 6.5.3 in /examples/keycloak/implicit/react Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.0 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.0...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> * Bump elliptic in /examples/keycloak/authorization/react Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.0 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.0...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> * Always setting hostname on all nodes of the cluster (on-prem fix) (#1509) * common: always setting hostname on all nodes of the cluster (on-prem fix) * updating 0.7.1 changelog * Workarund restart rabbitmq pods during patching #1395 * add missing changelog entry * Upgrade Kubernetes to v1.18.6 (#1501) * Upgrade k8s-dashboard to v2.0.3 (#1516) * fix due to review * Dashboard unavailability, network fix for Flannel and Canal #1394 (#1519) * additional defaults for kafka config * fixes after review, remove redundant code * Named demo configuration the same as generated one * Added deletion step description * Added a note related to versions for upgrades * Fixed syntax errors * Added prerequisites section in upgrade doc * Added key encoding troubleshooting info * Test fixes for RabbitMQ 3.8.3 (#1533) * fix missing variable image rabbitmq * Add Kubernetes Dashboard to COMPONENTS.md (#1546) * Update CHANGELOG-0.7.md Minor changes to changelog before release. * CHANGELOG-0.7.md update v0.7.1 release date (#1552) * Increment version string to 0.7.1 (#1554) Co-authored-by: Mateusz Kyc <[email protected]> Co-authored-by: Mateusz Kyc <[email protected]> Co-authored-by: Michał Opala <[email protected]> Co-authored-by: to-bar <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]> Co-authored-by: Tomasz Arendt <[email protected]> Co-authored-by: Marcin Pyrka <[email protected]> Co-authored-by: erzetpe <[email protected]> Co-authored-by: Luuk van Venrooij <[email protected]> Co-authored-by: ar3ndt <[email protected]> Co-authored-by: Grzegorz Dajuk <[email protected]> Co-authored-by: Grzegorz Dajuk <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: TolikT <[email protected]> Co-authored-by: przemyslavic <[email protected]>

add docker_version variable support

8fdf897

ghost self-assigned this Jul 17, 2020

ghost requested a review from to-bar July 17, 2020 10:37

to-bar changed the title ~~add docker_version variable support~~ Add docker_version variable support Jul 17, 2020

to-bar suggested changes Jul 17, 2020

View reviewed changes

Docker installation - 2 tasks merged into 1, to speed up the deployment

ae8c138

mkyc previously approved these changes Jul 21, 2020

View reviewed changes

Testing docker variables adjustments

2ced26f

ghost dismissed mkyc’s stale review via 2ced26f July 22, 2020 10:26

Remove two usless packages from docker installation

74e4777

Space char removed to provide proper yaml syntax

25e2c9a

to-bar previously approved these changes Jul 22, 2020

View reviewed changes

przemyslavic previously approved these changes Jul 22, 2020

View reviewed changes

Cosmetic fix

3a71db1

ghost dismissed stale reviews from przemyslavic and to-bar via 3a71db1 July 22, 2020 13:21

ghost requested review from mkyc and to-bar July 22, 2020 13:32

to-bar approved these changes Jul 22, 2020

View reviewed changes

przemyslavic approved these changes Jul 22, 2020

View reviewed changes

mkyc approved these changes Jul 22, 2020

View reviewed changes

ghost merged commit b19afc8 into develop Jul 22, 2020

ghost deleted the fix/802-docker-version-hardcoded branch July 22, 2020 14:19

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add docker_version variable support #1477

Add docker_version variable support #1477

ghost commented Jul 17, 2020 •

edited by ghost

Loading

mkyc commented Jul 17, 2020

ghost commented Jul 17, 2020

mkyc commented Jul 17, 2020

przemyslavic commented Jul 17, 2020

to-bar Jul 17, 2020

przemyslavic commented Jul 17, 2020

ghost commented Jul 17, 2020 •

edited by ghost

Loading

mkyc left a comment

ghost commented Jul 21, 2020

ghost commented Jul 22, 2020

mkyc left a comment

-docker_version: "5:18.09.*"
-docker_cli_version: "5:18.09.*"
-docker_version_rh: "3:18.09.*"
-docker_cli_version_rh: "1:19.03.*"
+docker_version:
+  Debian: "5:18.09.*"
+  RedHat: "18.09.*"

Add docker_version variable support #1477

Add docker_version variable support #1477

Conversation

ghost commented Jul 17, 2020 • edited by ghost Loading

mkyc commented Jul 17, 2020

ghost commented Jul 17, 2020

mkyc commented Jul 17, 2020

przemyslavic commented Jul 17, 2020

to-bar Jul 17, 2020

Choose a reason for hiding this comment

przemyslavic commented Jul 17, 2020

ghost commented Jul 17, 2020 • edited by ghost Loading

mkyc left a comment

Choose a reason for hiding this comment

ghost commented Jul 21, 2020

ghost commented Jul 22, 2020

mkyc left a comment

Choose a reason for hiding this comment

ghost commented Jul 17, 2020 •

edited by ghost

Loading

ghost commented Jul 17, 2020 •

edited by ghost

Loading