Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump rabbitmq version from 3.7.10 to 3.8.3 #1395 #1464

Merged
merged 2 commits into from
Aug 6, 2020
Merged

bump rabbitmq version from 3.7.10 to 3.8.3 #1395 #1464

merged 2 commits into from
Aug 6, 2020

Conversation

ar3ndt
Copy link
Contributor

@ar3ndt ar3ndt commented Jul 15, 2020

No description provided.

seriva
seriva reviewed Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@seriva seriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog entry pls.

jetalone85
jetalone85 previously approved these changes Jul 15, 2020
View reviewed changes
@przemyslavic
Copy link
Collaborator

And what about existing clusters with deployments in version 3.7.10? Upgrading/patching?

@jetalone85
Copy link
Contributor

And what about existing clusters with deployments in version 3.7.10? Upgrading/patching?

@ar3ndt correct me if I'm wrong, but there is no option to soft upgrade on this moment. Current upgrade process only patching image version on StatefulSet on memory manifest, then new version of pod has no created without manual delete old and lose data.

@ar3ndt
Copy link
Contributor Author

ar3ndt commented Jul 16, 2020

And what about existing clusters with deployments in version 3.7.10? Upgrading/patching?

@ar3ndt correct me if I'm wrong, but there is no option to soft upgrade on this moment. Current upgrade process only patching image version on StatefulSet on memory manifest, then new version of pod has no created without manual delete old and lose data.

yeah that would be kinda problematic with gracefully bumping it while there might be data in the queues.
Lets hold on with this

@ar3ndt ar3ndt mentioned this pull request Jul 28, 2020
Closed
@seriva
Copy link
Collaborator

seriva commented Jul 29, 2020

Missing changelog entry.

mkyc
mkyc reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@mkyc mkyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general question is: is that possible to have value 3.8.3 in some uber-vars? Can we have it from single place and then just change 3.7.10 to 3.8.3 in one line?

@ar3ndt
Copy link
Contributor Author

ar3ndt commented Aug 4, 2020

My general question is: is that possible to have value 3.8.3 in some uber-vars? Can we have it from single place and then just change 3.7.10 to 3.8.3 in one line?

I think so, maybe by the way of modularisation task.

@ar3ndt ar3ndt merged commit 78cbb2a into develop Aug 6, 2020
@atsikham atsikham deleted the feature/bump-rabbitmq-3.7-to-3.8 branch January 22, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriva seriva seriva left review comments

@mkyc mkyc mkyc approved these changes

@jetalone85 jetalone85 jetalone85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ar3ndt @przemyslavic @jetalone85 @seriva @mkyc