Vault MVP #1353
Merged
Vault MVP #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk4zuzu
suggested changes
Jun 17, 2020
core/src/epicli/data/common/ansible/playbooks/roles/vault/tasks/main.yml
Outdated
Show resolved
Hide resolved
...c/epicli/data/common/ansible/playbooks/roles/vault/templates/kubernetes/app-namespace.yml.j2
Show resolved
Hide resolved
sk4zuzu
previously approved these changes
Jun 18, 2020
mkyc
previously requested changes
Jun 19, 2020
| log_and_print "Vault is already unsealed. Nothing to do."; | ||
| elif [ "${command_result[1]}" = "1" ] ; then | ||
| log_and_print "Unsealing Vault..."; | ||
| grep --max-count=3 Unseal "$init_file_path" | awk '{print $4}' | while read -r line ; do |
There was a problem hiding this comment.
Magic number. init should be called with value and it should be passed here.
There was a problem hiding this comment.
Will be done after MVP.
core/src/epicli/data/common/ansible/playbooks/roles/vault/files/vault/configure-vault.sh
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/vault/files/vault/configure-vault.sh
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/vault/files/vault/configure-vault.sh
Show resolved
Hide resolved
| VAULT_PROTOCOL="${3:?missing argument}"; | ||
|
|
||
| PATH=$VAULT_INSTALL_PATH/bin:/usr/local/bin:$PATH; | ||
| export VAULT_ADDR="$VAULT_PROTOCOL://$VAULT_IP:8200" |
...ommon/ansible/playbooks/roles/vault/templates/kubernetes/vault-endpoint-configuration.yml.j2
Show resolved
Hide resolved
...ommon/ansible/playbooks/roles/vault/templates/kubernetes/vault-endpoint-configuration.yml.j2
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/vault/templates/vault/config.hcl.j2
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/vault/templates/vault/policy-admin.hcl.j2
Show resolved
Hide resolved
to-bar
force-pushed
the
feature/vault-mvp
branch
2 times, most recently
from
fe12336 to
30d2cfb
Compare
|
@erzetpe can you please also link issues related to this PR? |
This was
linked to
issues
Jun 22, 2020
…es authentication automatically with kubernetes integration.
…kubectl invocations
… to configure-vault.sh
…arate autounseal from autoconfiguration option Change counter naming in unseal-vault.sh script, change error handling Remove todos, run user creation only, when specified in Epiphany configuration, change default provisioner user name Fixes and additional logging
* Review: shell scripts * Rename certificate_generate.yml
ar3ndt
force-pushed
the
feature/vault-mvp
branch
from
30d2cfb to
d9e5a84
Compare
seriva
previously approved these changes
Jun 22, 2020
sk4zuzu
approved these changes
Jun 25, 2020
seriva
approved these changes
Jun 26, 2020
erzetpe
dismissed
mkyc’s stale review
Changes requested here will be done after MVP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is version MVP of Hashicorp Vault with Kubernetes integration