Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Refactor manifest file handling in cli #3186

Closed
11 of 20 tasks
sbbroot opened this issue Jun 8, 2022 · 0 comments
Closed
11 of 20 tasks

[FEATURE REQUEST] Refactor manifest file handling in cli #3186

sbbroot opened this issue Jun 8, 2022 · 0 comments
Assignees
Labels
python Pull requests that update Python code type/improvement

Comments

@sbbroot
Copy link
Contributor

sbbroot commented Jun 8, 2022

Is your feature request related to a problem? Please describe.

  1. We want to have unified naming for input/output manifest file across our code.
  2. For upgrade mode we need to provide manifest file with optimized list of images to download.

Describe the solution you'd like
Create unified mechanism for manifest handling across all cli/src/commands.

Describe alternatives you've considered

Additional context


DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@sbbroot sbbroot self-assigned this Jun 8, 2022
@sbbroot sbbroot added type/improvement python Pull requests that update Python code and removed status/grooming-needed labels Jun 8, 2022
sbbroot added a commit to sbbroot/epiphany that referenced this issue Aug 10, 2022
* Create the ManifestReader class for handling configuraton data used by
  the epicli

* Rename all of the manifest variables to input/output_manifest
sbbroot added a commit to sbbroot/epiphany that referenced this issue Aug 10, 2022
* Create the ManifestReader class for handling configuraton data used by
  the epicli

* Rename all of the manifest variables to input/output_manifest
sbbroot added a commit to sbbroot/epiphany that referenced this issue Aug 23, 2022
* Create the ManifestReader class for handling configuraton data used by
  the epicli

* Rename all of the manifest variables to input/output_manifest
sbbroot added a commit that referenced this issue Sep 8, 2022
* Refactor manifest file handling in cli (#3186)

* Create the ManifestReader class for handling configuraton data used by
  the epicli

* Rename all of the manifest variables to input/output_manifest
@seriva seriva closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code type/improvement
Projects
None yet
Development

No branches or pull requests

2 participants