Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] [download-requirements.py] Download files with deb and rpm extensions to packages subdirectory #3015

Closed
11 of 20 tasks
to-bar opened this issue Mar 11, 2022 · 0 comments

Comments

@to-bar
Copy link
Contributor

to-bar commented Mar 11, 2022

Is your feature request related to a problem? Please describe.
We have some packages (e.g. grafana) defined in files.yml. They are downloaded directly from URL (outside package repository) and saved into files sub-directory instead of packages. As consequence they are not part of epirepo package repository but installed using URL.

This has some drawbacks:

  1. More difficult dependency management
  2. Installation tasks require full URL and additional parameter (disable_gpg_check)
  3. dnf info shows @commandline instead of @epirepo

Describe the solution you'd like
If file from files.yml ends with .deb or .rpm it should be downloaded to packages sub-directory.
Then it will be part of epirepo package repository, so packages like grafana or rabbitmq should be installed in the same (simpler) way as others.

Describe alternatives you've considered
n/a

Additional context
n/a


DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@sbbroot sbbroot self-assigned this Mar 13, 2022
@przemyslavic przemyslavic self-assigned this Mar 15, 2022
sbbroot added a commit that referenced this issue Mar 22, 2022
… (#3020)

* Download files with deb and rpm extensions to packages subdirectory (#3015)
sbbroot added a commit to sbbroot/epiphany that referenced this issue Mar 24, 2022
* Fix an issue with optional files.yml missing
sbbroot added a commit to sbbroot/epiphany that referenced this issue Mar 24, 2022
* Fix an issue with optional files.yml missing
sbbroot added a commit that referenced this issue Mar 24, 2022
* Fix an issue with optional files.yml missing
@seriva seriva closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants