Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Upgrade] [Filebeat] All settings for multiline feature are lost after upgrade #2406

Closed
8 of 10 tasks
to-bar opened this issue Jun 30, 2021 · 1 comment
Closed
8 of 10 tasks

[BUG] [Upgrade] [Filebeat] All settings for multiline feature are lost after upgrade #2406

to-bar opened this issue Jun 30, 2021 · 1 comment
Assignees
@przemyslavic @to-bar
Labels
area/logs priority/high Task with high priority type/bug

Comments

@to-bar
Copy link
Contributor

to-bar commented Jun 30, 2021 •
edited by mkyc
Loading

Describe the bug
In Filebeat config file there are settings related to the multiline feature.

They are configurable via properties:

  • specification.common_input.multiline
  • specification.postgresql_input.multiline
  • specification.container_input.multiline

The properties are not defined in upgrade mode and they are removed from config file during upgrade.

The difference can be seen running this command:
diff /etc/filebeat/filebeat.yml.bak_7.9.2 /etc/filebeat/filebeat.yml

How to reproduce
Steps to reproduce the behavior:

  1. Deploy cluster using epicli v0.8.3.
  2. Upgrade the cluster using epicli v1.1.0rc1
  3. Compare Filebeat config file - current vs backed up

Expected behavior
Multiline settings preserved.

Environment

  • Cloud provider: All
  • OS: All

epicli version: 1.1.0rc1 and develop

Additional context
The bug was found by automated tests (PostgreSQL with enabled pgAudit).

DoD checklist

  • Changelog updated (if affected version was released)
  • COMPONENTS.md updated / doesn't need to be updated
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Case covered by automated test (if possible)
  • Idempotency tested
  • Documentation updated / doesn't need to be updated
  • All conversations in PR resolved
  • Backport tasks created / doesn't need to be backported
@to-bar to-bar changed the title [BUG] [upgrade] [Filebeat] All settings for multiline feature are removed during upgrade [BUG] [Upgrade] [Filebeat] All settings for multiline feature are lost after upgrade Jun 30, 2021
@to-bar to-bar self-assigned this Jun 30, 2021
@przemyslavic przemyslavic self-assigned this Jun 30, 2021
@przemyslavic
Copy link
Collaborator

przemyslavic commented Jun 30, 2021 •
edited
Loading

Filebeat support for multi-line messages has been tested after cluster upgrade.
✔️ upgrade from v0.8 to v1.1
✔️ upgrade from v0.9 to v1.1
✔️ upgrade from v1.0 to v1.1

@to-bar to-bar mentioned this issue Jun 30, 2021
Closed
9 tasks
@mkyc mkyc closed this as completed Jul 1, 2021
@seriva seriva mentioned this issue Jul 5, 2021
Merged
seriva added a commit that referenced this issue Jul 9, 2021
@seriva
Backports for #2406, #2127, #1576 (#2421)
ca8eae5 
* Added #2406

* Added #2127

* Added #1576

* Added spec changes for #2403 and #2407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslavic przemyslavic

@to-bar to-bar

Labels
area/logs priority/high Task with high priority type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkyc @przemyslavic @to-bar