[FEATURE REQUEST] Make Ansible code compliant with ansible-lint rules

[to-bar]

Is your feature request related to a problem? Please describe.
We've added ansible-lint to devcontainer and want to have code compliant with ansible-lint rules.

Describe the solution you'd like
No problems reported by ansible-lint.

Ansible-lint results as per 09/16/2021, probably want to re-run:
ansiblelint_results.txt

---

DoD checklist

• Changelog updated (if affected version was released)
• COMPONENTS.md updated / doesn't need to be updated
• Automated tests passed (QA pipelines)
  • apply
  • upgrade
• Case covered by automated test (if possible)
• Idempotency tested
• Documentation updated / doesn't need to be updated
• All conversations in PR resolved
• Backport tasks created / doesn't need to be backported

[rafzei]

I think its no longer valid - can you confirm @to-bar ?

[to-bar]

@rafzei It's still valid, here is an example: https://github.com/epiphany-platform/epiphany/blob/3e68564a9d765aa824382c03b8c3f8c65a49e1c5/core/src/epicli/data/common/ansible/playbooks/roles/image_registry/tasks/main.yml#L2

I think we could introduce the use of Ansible Lint (https://docs.ansible.com/ansible-lint/) and agree on the rules we want to follow, see issue 1176.

[rafzei]

Default ansible-lint rule for checking if name property exist:

502: All tasks should be named
  All tasks should have a distinct name for readability and for ``--start-at-task`` to work

[mkyc]

Should we rename it to something about Ansible lint?

[to-bar]

Should we rename it to something about Ansible lint?

IMHO the name is fine but it could be easier to do this task after #1176.

[mkyc]

It doesn't look like task for me but rather section in "code quality" document and part of DoD Check.

[to-bar]

It doesn't look like task for me but rather section in "code quality" document and part of DoD Check.

It is a task since some existing Ansible tasks are missing the name property. For improving code quality there is separate task (#1176 ). By introducing Ansible Lint we can likely ensure DoD check in this area automatically (with pipelines).

[asciible]

Waiting for completion of https://app.zenhub.com/workspaces/epiphany-platform-5ef9d3c749afc20019782391/issues/epiphany-platform/epiphany/2847

[rafzei]

@asciible hi, are you working on this issue? I see it's in todo and you are assigned.

[asciible]

I haven't started working on it. I was planning to start next week. Though you can take if you want. Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Rafal Zeidler ***@***.***> Sent: Thursday, March 3, 2022 9:00:15 PM To: epiphany-platform/epiphany ***@***.***> Cc: asciible ***@***.***>; Mention ***@***.***> Subject: Re: [epiphany-platform/epiphany] [FEATURE REQUEST] Make Ansible code compliant with ansible-lint rules (#1177) @asciible<https://github.com/asciible> hi, are you working on this issue? I see it's in todo and you are assigned. — Reply to this email directly, view it on GitHub<#1177 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWKCNNGJK7MMFH7ULJCCIDLU6EK47ANCNFSM4MNHFLGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>