Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add byte length override for transfer fee estimates #1763

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: Add byte length override for transfer fee estimates #1763

merged 1 commit into from
Nov 15, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Nov 14, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 7.0.3-pr.0+d7269c8c
e.g. npm install @stacks/[email protected]+d7269c8c --save-exact

  • alternative if we don't have a transaction

@janniks janniks requested a review from He1DAr November 14, 2024 20:30
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 8:31pm

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transactions/src/fetch.ts 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks changed the title fix: Add byte length override the transfer fee estimate fix: Add byte length override for transfer fee estimates Nov 14, 2024
@janniks janniks enabled auto-merge (squash) November 14, 2024 21:04
@janniks janniks merged commit a789994 into main Nov 15, 2024
10 checks passed
@janniks janniks deleted the fix/add-tx-length-override branch November 15, 2024 15:10
@blockstack-devops blockstack-devops mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

@He1DAr He1DAr Awaiting requested review from He1DAr

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @rafaelcr