Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added elevation to redesign #1865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: added elevation to redesign #1865

wants to merge 1 commit into from
+151 −0

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Oct 16, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added elevation to theme for redesign

Issue ticket number and link

#1845

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

@BLuEScioN BLuEScioN requested a review from He1DAr October 16, 2024 20:54
@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 11:55pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 11:55pm

@BLuEScioN BLuEScioN linked an issue Oct 16, 2024 that may be closed by this pull request
Design system: Implement elevantion #1845
Open
@BLuEScioN BLuEScioN mentioned this pull request Oct 16, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stories/Elevation.stories.tsx 0.00% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ginny-d
Copy link

ginny-d commented Oct 18, 2024

Are the ones for dark mode missing?

Screenshot 2024-10-18 at 12 14 08

@BLuEScioN
Copy link
Collaborator Author

Are the ones for dark mode missing?

Screenshot 2024-10-18 at 12 14 08

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1DAr He1DAr Awaiting requested review from He1DAr

@ginny-d ginny-d Awaiting requested review from ginny-d

@andresgalante andresgalante Awaiting requested review from andresgalante

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Stacks Explorer
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design system: Implement elevantion
2 participants
@BLuEScioN @ginny-d