Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve vitest matcher sources resolver #1514

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

hugocaillard
Copy link
Collaborator

Superseding #1500

From @bradleyayers:

The location of node_modules is not guaranteed to be relative to the current directory (e.g. in workspaces). A better solution here is to update package.json exports to include the file.

This fixes it and also update some of the sdk dependencies.

The fix is available and can be tested with npm i --force @hirosystems/[email protected].
I also tested in an npm workspace setup (not tested with pnpm or yarn, @bradleyayers let me know if you can give it a try)

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@hugocaillard hugocaillard merged commit 0cd1b95 into main Jul 19, 2024
19 checks passed
@hugocaillard hugocaillard deleted the fix/sdk-vitest-helper-path-resolver branch July 19, 2024 17:43
@hugocaillard hugocaillard mentioned this pull request Jul 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant