Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add options to enable or disable costs and coverage reports in sdk #1441

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Apr 26, 2024

Description

To be rebased on main and merged after #1437

The sdk was always tracking costs and coverage reports even when it wasn't enabled.
By only enabling it when needed, we get better performance

MicaiahReid
MicaiahReid previously approved these changes Apr 26, 2024
components/clarinet-sdk/tests/reports.test.ts Show resolved Hide resolved
Base automatically changed from fix/improved-simnet-deployment-plan-handling to main April 26, 2024 15:41
@hugocaillard hugocaillard dismissed MicaiahReid’s stale review April 26, 2024 15:41

The base branch was changed.

@hugocaillard hugocaillard force-pushed the fix/skip-reports-in-regular-tests branch from 972b7f2 to f071e9d Compare April 26, 2024 15:42
@hugocaillard hugocaillard changed the title [DO NOT MERGE] fix: add options to enable or disable costs and coverage reports in sdk fix: add options to enable or disable costs and coverage reports in sdk Apr 26, 2024
@hugocaillard hugocaillard merged commit fd761e4 into main Apr 26, 2024
16 checks passed
@hugocaillard hugocaillard deleted the fix/skip-reports-in-regular-tests branch April 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants