Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce the stacks-codec component #1399

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Mar 28, 2024

Description

  • introduce a stacks-codec component, extracting the codec that was in clarity-repl
  • making stacks-rpc-client lighter by not pulling the whole clarity-repl component but just stacks-codec
  • making chainhook-sdk lighter by not pulling the whole stacks-rpc-client component but just stacks-codec
  • remove the default values for PoxInfo

This goes in pair with hirosystems/chainhook#542

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.91%. Comparing base (175103e) to head (3e81431).

❗ Current head 3e81431 differs from pull request most recent head c796160. Consider uploading reports for the commit c796160 to get more accurate results

Files Patch % Lines
...omponents/stacks-network/src/chains_coordinator.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
+ Coverage   40.87%   40.91%   +0.04%     
==========================================
  Files          87       87              
  Lines       32562    32519      -43     
==========================================
- Hits        13309    13305       -4     
+ Misses      19253    19214      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgalabru
Copy link
Contributor

Address #1038

@hugocaillard hugocaillard marked this pull request as ready for review March 29, 2024 13:45
MicaiahReid
MicaiahReid previously approved these changes Mar 29, 2024
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, thanks for doing this, @hugocaillard!

@hugocaillard hugocaillard merged commit 83e1383 into main Mar 29, 2024
4 checks passed
@hugocaillard hugocaillard deleted the feat/stacks-codec branch March 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants