Backslash not removed when escaping quotes in strings

[hugocaillard]

On clarinet the escaping backslashes are not removed in strings (ascii or utf8).
On the testnet it works as intended

Code to reproduce:

(define-public (say-hello)
  ;; returns `Hello \"World\"` instead of `Hello "World"`
  (ok "Hello \"World\"")
)

I also realised that backslashes are added before single quotes. Please tell me if I should open a second issue about that

(define-public (say-hello2)
  ;; returns `Hello \'World\'` instead of `Hello 'World'`
  (ok "Hello 'World'")
)

[lgalabru]

Interesting, thanks for opening this issue.
Clarinet should probably be dumping .clar files in vector of bytes that we would pass to the clarity-repl.
Thoughts @obycode?

[obycode]

Interesting... the string is un-escaped after the parser. I'll dig into it a bit more.

[obycode]

I believe the problem is that the result of mine block is being processed by a format! (deno.rs:1218)

    Some(output) => format!("{}", output),

And the implementation for the String clarity value uses this function from clarity/types/mod.rs:415:

impl fmt::Display for ASCIIData {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        let mut escaped_str = String::new();
        for c in self.data.iter() {
            let escaped_char = format!("{}", std::ascii::escape_default(*c));
            escaped_str.push_str(&escaped_char);
        }
        write!(f, "{}", format!("\"{}\"", escaped_str))
    }
}

I should be able to fix it tomorrow.

[obycode]

Ok, I've got a fix in 5505ad8. I'm going to add some unit tests before opening a PR. I've basically just added a recursive function to print the Values instead of using the Display trait as defined in the clarity library, since that is where the character encoding happens. If either of you have a better name for this function, let me know (currently value_to_string).

[hugocaillard]

Tested locally and it's fixed 🙌
Thx

[blockstack-devops]

🎉 This issue has been resolved in version 0.24.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀