Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis conn #442

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: redis conn #442

merged 2 commits into from
Oct 11, 2023

Conversation

lgalabru
Copy link
Contributor

This PR is fixing the management of the redis connection. In the current approach, we're reusing an existing connection that is being opened at startup for test purposes, but that can get broken after some time if blocks take time to arrive.
Fix: we open/close a new connection every time a new block hits the API.

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lgalabru lgalabru temporarily deployed to Development-mainnet October 11, 2023 14:24 — with GitHub Actions Inactive
@lgalabru lgalabru temporarily deployed to Development-testnet October 11, 2023 14:24 — with GitHub Actions Inactive
@lgalabru lgalabru temporarily deployed to Staging-mainnet October 11, 2023 14:33 — with GitHub Actions Inactive
@lgalabru lgalabru temporarily deployed to Staging-testnet October 11, 2023 14:33 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid merged commit 80737ad into develop Oct 11, 2023
10 checks passed
@MicaiahReid MicaiahReid deleted the fix/redis-conn branch October 11, 2023 14:37
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
## [1.1.1](v1.1.0...v1.1.1) (2023-10-11)

### Bug Fixes

* add auth header for stacks hook ([#444](#444)) ([8c4e5ea](8c4e5ea)), closes [#438](#438)
* don't evaluate transactions for block predicates ([#445](#445)) ([0e84fe7](0e84fe7))
* redis conn ([#442](#442)) ([80737ad](80737ad))
@github-actions
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

vabanaerytk added a commit to vabanaerytk/chainhook that referenced this pull request Aug 7, 2024
## [1.1.1](hirosystems/chainhook@v1.1.0...v1.1.1) (2023-10-11)

### Bug Fixes

* add auth header for stacks hook ([#444](hirosystems/chainhook#444)) ([3d0ad07](hirosystems/chainhook@3d0ad07)), closes [#438](hirosystems/chainhook#438)
* don't evaluate transactions for block predicates ([#445](hirosystems/chainhook#445)) ([ac3d726](hirosystems/chainhook@ac3d726))
* redis conn ([#442](hirosystems/chainhook#442)) ([5e6d704](hirosystems/chainhook@5e6d704))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants