Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streaming predicates never set interrupted status #523

Closed
MicaiahReid opened this issue Mar 13, 2024 · 2 comments · Fixed by #574
Closed

streaming predicates never set interrupted status #523

MicaiahReid opened this issue Mar 13, 2024 · 2 comments · Fixed by #574
Assignees
@MicaiahReid
Labels
released
Milestone
Production Reliab...

Comments

@MicaiahReid
Copy link
Contributor

If a predicate is in streaming mode and it fails (for example when being triggered and sending the payload to the user), we don't set the status to interrupted. This means platform users will never see the errors, and if the user's service is no longer receiving requests we'll keep this predicate around for ever.
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Mar 13, 2024
@MicaiahReid
Copy link
Contributor Author

Example:

chainhook/components/chainhook-sdk/src/observer/mod.rs

Line 1168 in b3e938a

for (request, data) in requests.into_iter() {

@MicaiahReid MicaiahReid moved this from 🆕 New to 📋 Backlog in DevTools Mar 13, 2024
@MicaiahReid MicaiahReid added this to the Production Reliability milestone Mar 13, 2024
@MicaiahReid MicaiahReid self-assigned this Mar 13, 2024
@MicaiahReid MicaiahReid mentioned this issue May 1, 2024
Merged
@MicaiahReid MicaiahReid moved this from 📋 Backlog to 👀 In Review in DevTools May 6, 2024
MicaiahReid added a commit that referenced this issue May 7, 2024
@MicaiahReid
fix: set Interrupted status for streaming predicates that fail (#574)
900d6df 
Fixes #523
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in DevTools May 7, 2024
MicaiahReid added a commit that referenced this issue May 8, 2024
@MicaiahReid
fix: set Interrupted status for streaming predicates that fail (#574)
11bde53 
Fixes #523
github-actions bot pushed a commit that referenced this issue May 9, 2024
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
adda6ec 
## [1.6.0](v1.5.1...v1.6.0) (2024-05-09)

### Features

* add Bitcoin transaction index to typescript client ([#568](#568)) ([6f7eba4](6f7eba4))

### Bug Fixes

* add stacks event position to ts client ([#575](#575)) ([3c48eeb](3c48eeb))
* add starting stacks height for prometheus metrics ([#567](#567)) ([6a8c086](6a8c086))
* make bitcoin payload serialization deserializable ([#569](#569)) ([5f20a86](5f20a86))
* set `Interrupted` status for streaming predicates that fail ([#574](#574)) ([11bde53](11bde53)), closes [#523](#523)
* shut down observer on bitcoin block download failure ([#573](#573)) ([f3530b7](f3530b7)), closes [#572](#572)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BrewTestBot BrewTestBot mentioned this issue May 9, 2024
Merged
vabanaerytk added a commit to vabanaerytk/chainhook that referenced this issue Aug 7, 2024
@vabanaerytk @semantic-release-bot
chore(release): 1.6.0 [skip ci]
1927ce6 
## [1.6.0](hirosystems/chainhook@v1.5.1...v1.6.0) (2024-05-09)

### Features

* add Bitcoin transaction index to typescript client ([#568](hirosystems/chainhook#568)) ([2ca8608](hirosystems/chainhook@2ca8608))

### Bug Fixes

* add stacks event position to ts client ([#575](hirosystems/chainhook#575)) ([3a9b1fb](hirosystems/chainhook@3a9b1fb))
* add starting stacks height for prometheus metrics ([#567](hirosystems/chainhook#567)) ([b2296aa](hirosystems/chainhook@b2296aa))
* make bitcoin payload serialization deserializable ([#569](hirosystems/chainhook#569)) ([4c0c03b](hirosystems/chainhook@4c0c03b))
* set `Interrupted` status for streaming predicates that fail ([#574](hirosystems/chainhook#574)) ([11282b0](hirosystems/chainhook@11282b0)), closes [#523](hirosystems/chainhook#523)
* shut down observer on bitcoin block download failure ([#573](hirosystems/chainhook#573)) ([db1c566](hirosystems/chainhook@db1c566)), closes [#572](hirosystems/chainhook#572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MicaiahReid MicaiahReid

Labels
released
Projects
DevTools
Archived in project
Milestone
Production Reliability
Development

Successfully merging a pull request may close this issue.

fix: set Interrupted status for streaming predicates that fail hirosystems/chainhook
1 participant
@MicaiahReid