-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ft_event scope missing transfer events #469
Comments
Hi @Xarek-Wizard thanks for the issue. I've been able to confirm this behavior. It's interesting, when I use this predicate:
so that it's just the block with txid I will continue looking into this. @lgalabru I'm curious if you have any hunches |
### Description When evaluatin a stacks predicate of type `ft_event` or `nft_event`, we were returning from a loop of all events after the first loop. We should only return early if there is a match, and should continue searching all events if there isn't. This PR implements that fix. Fixes #469 --- ### Checklist - [x] All tests pass - [x] Tests added in this PR (if applicable)
### Description When evaluatin a stacks predicate of type `ft_event` or `nft_event`, we were returning from a loop of all events after the first loop. We should only return early if there is a match, and should continue searching all events if there isn't. This PR implements that fix. Fixes #469 --- ### Checklist - [x] All tests pass - [x] Tests added in this PR (if applicable)
## [1.3.0](v1.2.1...v1.3.0) (2024-02-08) ### Features * optionally serve Prometheus metrics ([#473](#473)) ([67a38ac](67a38ac)) ### Bug Fixes * adjust ordinal_number entry in ts client inscription transfer event, add new reveal data ([#476](#476)) ([28bf5c4](28bf5c4)) * remove early return for event evaluation ([#484](#484)) ([98f9e86](98f9e86)), closes [#469](#469) * remove unreachable panic; return instead ([#490](#490)) ([abe0fd5](abe0fd5)) * use cli feature for `cargo chainhook-install` ([#486](#486)) ([32f4d4e](32f4d4e)) * validate predicate `start_block` and `end_block` ([#489](#489)) ([e70025b](e70025b)), closes [#477](#477) [#464](#464)
🎉 This issue has been resolved in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.3.0](hirosystems/chainhook@v1.2.1...v1.3.0) (2024-02-08) ### Features * optionally serve Prometheus metrics ([#473](hirosystems/chainhook#473)) ([1a3e356](hirosystems/chainhook@1a3e356)) ### Bug Fixes * adjust ordinal_number entry in ts client inscription transfer event, add new reveal data ([#476](hirosystems/chainhook#476)) ([fe7ef78](hirosystems/chainhook@fe7ef78)) * remove early return for event evaluation ([#484](hirosystems/chainhook#484)) ([d0e2f60](hirosystems/chainhook@d0e2f60)), closes [#469](hirosystems/chainhook#469) * remove unreachable panic; return instead ([#490](hirosystems/chainhook#490)) ([c7894ac](hirosystems/chainhook@c7894ac)) * use cli feature for `cargo chainhook-install` ([#486](hirosystems/chainhook#486)) ([206cb17](hirosystems/chainhook@206cb17)) * validate predicate `start_block` and `end_block` ([#489](hirosystems/chainhook#489)) ([85f3e71](hirosystems/chainhook@85f3e71)), closes [#477](hirosystems/chainhook#477) [#464](hirosystems/chainhook#464)
Utilising the following predicate:
The transaction ID
0xa62ad0db39c4dbc9cef589e653e003935dfc1413624c1c7d287cbe0e94d9dc41
does not appear. This transaction contains the following receipt event, which makes me believe it should be present:Snagging predicate:
The text was updated successfully, but these errors were encountered: