Postgres support #28
Merged
Postgres support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very related laravel/pulse#64 |
morrislaptop
commented
Dec 6, 2023
added 2 commits
December 6, 2023 11:39
morrislaptop
changed the title
|
Thank you for working on this! I'm going to get our automated tests fully running with MySQL and Postgres and then take a look. Any changes to the github actions in PRs won't take effect until merged, so it's easier to have Postgres tests running on |
|
No problems! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was tracking down #17 and discovered that multiple states for the same ID are being written to the database.
SQLite and MySQL don't seem to care, but Postgres throws an error. At the very least this will be a performance improvement in sending less data over the wire.
This fixes the issue, although the purpose of the PR is to just highlight the root cause of the same state going into the queue to be written.
Cheers,
Craig