Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario
Currently if you have a property that has a
StateId
set tonull
, Verbs will generate an ID for it.But there are some scenarios where a property should actually be set to
null
and no new ID/ state should get generated for it, as it's an optional reference to another state.To solve this, we can use the
autofill: false
property on theStateId
attribute.The problem
The problem is that at the moment, doing the above code throws the following error:
The solution
This PR fixes it by ensuring that when the
EventStateRegistry
discovers states, that it has actually found a state before trying to process the aliases.I couldn't see any unit tests for
StateId
so I have added a basic test and added 2 tests that cover theautofill: false
scenarios.