Merge pull request #59 from hirethunk/daniel/fix-stupid-boolean-check

Fix the stupidest type check ever.
hirethunk · Feb 13, 2024 · eb8edca · eb8edca
2 parents 3b782be + b9b34d1
commit eb8edca
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/Lifecycle/Guards.php b/src/Lifecycle/Guards.php
@@ -68,7 +68,7 @@ protected function passesAuthorization(): bool
                 return $result->authorize();
             }
 
-            if ($result instanceof bool) {
+            if (is_bool($result)) {
                 return $result;
             }
 

diff --git a/tests/Feature/PendingEventChecksTest.php b/tests/Feature/PendingEventChecksTest.php
@@ -22,6 +22,20 @@
     $this->assertFalse($event->isAllowed());
 });
 
+it('supports boolean authorization', function () {
+    $event = EventWithBooleanAuth::make([
+        'allowed' => true,
+    ]);
+
+    $this->assertTrue($event->isAllowed());
+
+    $event = EventWithBooleanAuth::make([
+        'allowed' => false,
+    ]);
+
+    $this->assertFalse($event->isAllowed());
+});
+
 it('can test validation on a pending event', function () {
     SpecialState::factory()->create([
         'name' => 'daniel',
@@ -60,6 +74,16 @@
     $this->assertFalse($event->isValid());
 });
 
+class EventWithBooleanAuth extends Event
+{
+    public bool $allowed;
+
+    public function authorize()
+    {
+        return $this->allowed;
+    }
+}
+
 class EventWithMultipleStates extends Event
 {
     #[StateId(SpecialState::class)]