Add test case for sub components (demonstrates invalid syntax in output) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like webpack can expect this method to be defined in certain cases. Related to storybookjs/storybook#15221.
This change adds the needed check for webpack 5 to avoid extra processing. Ported from #45.
fix: Fix rebuild performance for webpack 5
stevenpetryk
commented
Jan 28, 2022
| pull_request: | ||
| branches: | ||
| - master | ||
| - main | ||
| - next |
There was a problem hiding this comment.
Sorry, I think I cloned Storybook's fork of this project. Some of these changes are unrelated. But check out the snapshot below :)
stevenpetryk
commented
Jan 28, 2022
Comment on lines
+234
to
+236
| default.Sub.displayName = \\"default.Sub\\"; | ||
| // @ts-ignore | ||
| default.Sub.__docgenInfo = { \\"description\\": \\"\\", \\"displayName\\": \\"default.Sub\\", \\"props\\": { \\"name\\": { \\"defaultValue\\": null, \\"description\\": \\"\\", \\"name\\": \\"name\\", \\"required\\": true, \\"type\\": { \\"name\\": \\"string\\" } } } }; |
There was a problem hiding this comment.
Syntax errors here (so even the defensive try/catch doesn't help :(
stevenpetryk
commented
Jan 28, 2022
| @@ -143,6 +143,18 @@ export default class DocgenPlugin implements webpack.WebpackPluginInstance { | |||
| } | |||
There was a problem hiding this comment.
Irrelevant file, sorry again!
|
Just gonna close this, too messy. Fixing my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to demonstrate/add a test case for the invalid output described in #57. It stems from a bug in
react-docgen-typescriptwhere components that are assigned to properties of other components are given a name ofdefault.Name.The snapshot that gets generated by the test suite for this (valid) file contains a syntax error.