WIP: Compute image ipix and only update masked indices in all sky image #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #79. Previously, the output image contained bright lines as the values were being summed twice at tile edges. The current change applies the resulting tile image only at certain indices, which it receives by applying a mask on the all sky image based on the ipix values.
Previous output:
Current output:
However, the updated output image now contains 'holes' where pixels values are not inserted. I believe this is an issue with the warping function we're currently using. I will trying using either
skimage.transform.warp_coords
orscipy.ndimage.map_coordiantes
and see if it resolves the issue.