Add healpix to hips conversion method #123
Conversation
There was a problem hiding this comment.
@adonath - This is great, thanks!
A high-level docs page with one example would be great.
I also think a unit test for healpix_to_hips_tile asserting on one or two pixel values would be good to have.
Let me know if you have time to apply these suggestions, or if I should do it tomorrow.
hips/draw/healpix.py
Outdated
| filename.parent.mkdir(exist_ok=True, parents=True) | ||
| tile.write(filename=filename) | ||
|
|
||
| # Write a minimal property file |
There was a problem hiding this comment.
I think this class it a dict representation of the properties file?
https://hips.readthedocs.io/en/latest/api/hips.HipsSurveyProperties.html
Can you use it here and add the to_string and write there if it doesn't exit already?
Either way I'd suggest to use this for the write text:
https://docs.python.org/3/library/pathlib.html#pathlib.Path.write_text
It also closes the file on the end of the method call, and is one line less and doesn't need the with and local variable f, i.e. ist just a bit simpler overall.
|
@cdeil OK to add the high level docs example later, once the support for color image is added? |
|
Sure |
|
@adonath - Thanks! |
This PR adds the healpix to hips conversion functionality. It is exposed via the method
healpix_to_hips.I added a simple test using a healpix image filled with
np.arange()in the nested scheme and compared the sum of the indices to manually created reference values. I also added anenvironment.ymldefining ahips-devenvironment.