Include memory stats when memory warning occurs. #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
southerneer
reviewed
Mar 11, 2020
|
|
||
| const App = () => { | ||
| const [store, setStore] = useState<any>(null) | ||
|
|
||
| useEffect(() => { | ||
| // This seems to be undocumented event. | ||
| AppState.addEventListener('memoryWarning', () => { | ||
| const extras = {currentState: AppState.currentState} | ||
| AppState.addEventListener('memoryWarning', async () => { |
There was a problem hiding this comment.
Since we're doing this on a top-level component we probably don't need to worry about removing this listener later, but just something to think about if we start to see performance drop-off
There was a problem hiding this comment.
Ah, I guess this listener has been in for a while already.
There was a problem hiding this comment.
When I implemented the listener (it was a long time ago), it was pre-useEffect and AppState.addEventListener was supposed to happen only once per app invocation. Hence, I didn't see a need to remove it.
Are you implying that, after it was moved into useEffect, it can happen more than once?
If so, then ... how about moving it back outside of useEffect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to get stats from real world devices.
Just trying to help with #4055.
Since @aksonov is working on #4055, this should be reviewed by him (at least).