Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavonEditor - Cross-Site Scripting - Fix: #548

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Conversation

huntr-helper
Copy link
Contributor

@huntr-helper huntr-helper commented Mar 7, 2020

https://github.com/Asjidkalam fixed the vulnerability associated with Cross-Site Scripting.
This fix is being submitted on behalf of https://github.com/Asjidkalam - they have been awarded $25 for fixing the vulnerability through the huntr bug bounty program.
Think you could fix a vulnerability like this - get involved (https://huntr.dev).
Q | A
Version Affected | ALL
Bug Fix | YES
Further References | 418sec#1
Related Issue | #472

Original Comments:

Bug fix:
Sanitized the input value on the textarea of the vNoteEdit panel using the xss module, so that it escapes all the inputs resulting in an XSS.

The XSS mitigation is implemented inside the watch: { value: function (val, oldVal) }, which passes the val variable through the xss() and return the escaped output to the d_value variable.

Files changed:

package.json
mavon-editor.vue

Bounty URL: https://huntr.dev/bounties/1-npm-mavon-editor

Asjid Kalam and others added 4 commits February 29, 2020 23:53
@JamieSlome
Copy link

@leftstick @cyyjs @clarifysky - any updates on this?

@hinesboy hinesboy merged commit ff5c11d into hinesboy:master Apr 1, 2020
@asgarth
Copy link

asgarth commented Apr 11, 2020

@hinesboy this PR broke the ability to use HTML code in the editor. Now it's not possible anymore to do something like this:

<span class="success">Success</span>

Also probably this other PR already solved the issue: #538

If this is really required please at least add some props to customize the method used and whitelist some tags/attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants