Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing audit log entry converter & AuditLogChangeKey #1996

Merged

Conversation

syncblaze
Copy link
Contributor

Summary

AuditLogEntrys with action type MEMBER_UPDATE can have a communication_disabled_until ChangeKey, if their timeout was added/changed/removed. This was not converted and deserialized as a str until now, so i added the needed converter & ChangeKey

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice catch, thank you!

changes/1996.bugfix.md Outdated Show resolved Hide resolved
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@davfsa davfsa enabled auto-merge (squash) August 4, 2024 15:11
@davfsa davfsa disabled auto-merge August 4, 2024 15:11
@davfsa davfsa enabled auto-merge (squash) August 4, 2024 15:11
@davfsa davfsa merged commit 88c13fb into hikari-py:master Aug 4, 2024
27 checks passed
@syncblaze syncblaze deleted the add_missing_audit_log_entry_converter branch August 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants