Add title and description fields to Attachment

changes/1945.feature.md

@@ -0,0 +1 @@
+Add `title` and `description` fields to `Attachment`.

hikari/impl/entity_factory.py

@@ -2968,6 +2968,8 @@ def _deserialize_message_attachment(self, payload: data_binding.JSONObject) -> m
         return message_models.Attachment(
             id=snowflakes.Snowflake(payload["id"]),
             filename=payload["filename"],
+            title=payload.get("title"),
+            description=payload.get("description"),
             media_type=payload.get("content_type"),
             size=int(payload["size"]),
             url=payload["url"],

hikari/messages.py

@@ -213,7 +213,17 @@ class Attachment(snowflakes.Unique, files.WebResource):
     """The source URL of file."""
 
     filename: str = attrs.field(hash=False, eq=False, repr=True)
-    """The name of the file."""
+    """The filename of the file."""
+
+    title: typing.Optional[str] = attrs.field(hash=False, eq=False, repr=True)
+    """The title of the file.
+
+    This will be the original filename of the attachment if it contained
+    non-unicode characters.
+    """
+
+    description: typing.Optional[str] = attrs.field(hash=False, eq=False, repr=True)
+    """The description of the file."""
 
     media_type: typing.Optional[str] = attrs.field(hash=False, eq=False, repr=True)
     """The media type of the file."""

tests/hikari/impl/test_entity_factory.py

@@ -5650,6 +5650,8 @@ def attachment_payload(self):
         return {
             "id": "690922406474154014",
             "filename": "IMG.jpg",
+            "title": "IMGA",
+            "description": "description",
             "content_type": "image/png",
             "size": 660521,
             "url": "https://somewhere.com/attachments/123/456/IMG.jpg",
@@ -5719,6 +5721,8 @@ def test__deserialize_message_attachment(self, entity_factory_impl, attachment_p
 
         assert attachment.id == 690922406474154014
         assert attachment.filename == "IMG.jpg"
+        assert attachment.title == "IMGA"
+        assert attachment.description == "description"
         assert attachment.size == 660521
         assert attachment.media_type == "image/png"
         assert attachment.url == "https://somewhere.com/attachments/123/456/IMG.jpg"
@@ -5741,6 +5745,8 @@ def test__deserialize_message_attachment_with_null_fields(self, entity_factory_i
         assert isinstance(attachment, message_models.Attachment)
 
     def test__deserialize_message_attachment_with_unset_fields(self, entity_factory_impl, attachment_payload):
+        del attachment_payload["title"]
+        del attachment_payload["description"]
         del attachment_payload["content_type"]
         del attachment_payload["height"]
         del attachment_payload["width"]
@@ -5750,6 +5756,8 @@ def test__deserialize_message_attachment_with_unset_fields(self, entity_factory_
 
         attachment = entity_factory_impl._deserialize_message_attachment(attachment_payload)
 
+        assert attachment.title is None
+        assert attachment.description is None
         assert attachment.media_type is None
         assert attachment.height is None
         assert attachment.width is None
@@ -5967,6 +5975,8 @@ def test_deserialize_message(
         attachment = message.attachments[0]
         assert attachment.id == 690922406474154014
         assert attachment.filename == "IMG.jpg"
+        assert attachment.title == "IMGA"
+        assert attachment.description == "description"
         assert attachment.size == 660521
         assert attachment.url == "https://somewhere.com/attachments/123/456/IMG.jpg"
         assert attachment.proxy_url == "https://media.somewhere.com/attachments/123/456/IMG.jpg"

tests/hikari/test_messages.py

@@ -39,6 +39,8 @@ def test_str_operator(self):
         attachment = messages.Attachment(
             id=123,
             filename="super_cool_file.cool",
+            title="other title",
+            description="description!",
             media_type="image/png",
             height=222,
             width=555,