Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the defaultConfigDisable of WasmPlugin CR to false by default #369

Merged

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Nov 18, 2024

Ⅰ. Describe what this PR did

Set the defaultConfigDisable of WasmPlugin CR to false by default, so it won't break the WasmPlugin config pushing if user only configures plugin in route or domain level.

Ⅱ. Does this pull request fix one issue?

fixes alibaba/higress#1517

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 9693ac2 into higress-group:main Nov 18, 2024
4 checks passed
@CH3CHO CH3CHO deleted the fix/wasmplugin-disable-by-default branch November 19, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Higress版本升级后插件不生效了
2 participants