Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compensate WasmPlugin.phase field if not set in the CR #244

Merged

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jul 31, 2023

Ⅰ. Describe what this PR did

Compensate WasmPlugin.phase field with the default value if it's not set in the CR

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni July 31, 2023 13:03
@CH3CHO CH3CHO requested a review from xiangxiuhui as a code owner July 31, 2023 13:03
@johnlanni johnlanni merged commit 8fba2d6 into higress-group:main Aug 1, 2023
@CH3CHO CH3CHO deleted the fix/comp-wasmplugin-default-phase branch August 1, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants