New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for getAnOrder() method #16

Open

jmwill86 wants to merge 4 commits into highsidelabs:main from jmwill86:bugfix/getAnOrder

jmwill86 commented Nov 16, 2023

Fixes getanOrder() returning null on any order fetch. Majority of amends here are auto code cleanup. Functional changes are:

->order added in src/Apis/MP/US/OrdersApi.php to enable properties to be found in the deserializer.
sanitizeTimestamp function was throwing an exception on unix values, and unix values are microseconds.
Fix for return values of OrderLine

There's probably some improvements to be made to my amends but I don't have a lot of time to commit currently.

jmwill86 added 4 commits

November 15, 2023 17:39


          order lin fix

d09f770


          getanOrder fix

aa7749a


          code cleanup

bb0a589


          deserializer time fix

009eee9

jmwill86 changed the title ~~Bugfix/get an order~~ Bugfix for getAnOrder() method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet